<html>
<head>
<meta content="text/html; charset=UTF-8" http-equiv="Content-Type">
</head>
<body text="#000000" bgcolor="#FFFFFF">
<div class="moz-cite-prefix">On 9/4/2013 21:16, Jactry Zeng wrote:<br>
</div>
<blockquote
cite="mid:CAManwEx3GSneWXCKJnsZAL5MQrwKcVQ2Uq1Mqx=vLjgutHQJLQ@mail.gmail.com"
type="cite">
<div dir="ltr">Hi Nikolay,<br>
<div><br>
2013/9/5 Nikolay Sivov <<a moz-do-not-send="true"
href="mailto:bunglehead@gmail.com" target="_blank">bunglehead@gmail.com</a>><br>
><br>
> On 9/4/2013 07:17, Jactry Zeng wrote:<br>
>><br>
>> - ME_EndToUnicode(unicode, wszText);<br>
>> + ME_EndToUnicode(unicode ? 1200 : CP_ACP,
wszText);<br>
><br>
> It's still ugly to use magic numbers like that, in a
similar situation I had some time<br>
> ago I use ~0 to mark WCHAR data encoding that does need
special handling.<br>
> Even with a value like ~0 it needs to be documented in
code comments.<br>
><br>
<br>
Thanks for your review! <br>
But I still can't understand it. :( Can you show me a commit
as an example.<br>
</div>
</div>
</blockquote>
What I mean is it's better to use something more neutral to mark an
absence of<br>
codepage.<br>
<br>
In my case it was like that <a
href="http://source.winehq.org/git/wine.git/commit/320d419be1fe713c50eac7d53e4dc52481fad8b7">http://source.winehq.org/git/wine.git/commit/320d419be1fe713c50eac7d53e4dc52481fad8b7</a>
<blockquote
cite="mid:CAManwEx3GSneWXCKJnsZAL5MQrwKcVQ2Uq1Mqx=vLjgutHQJLQ@mail.gmail.com"
type="cite">
<div dir="ltr">
<div><br>
Thank you!<br>
<br>
(sorry for forgeting cc wine-devel)<br>
--<br>
Regards,<br>
Jactry Zeng<br>
</div>
</div>
</blockquote>
<br>
</body>
</html>