<div dir="ltr">Good point, I'll extend the test<br></div><div class="gmail_extra"><br><br><div class="gmail_quote">2014-04-24 13:25 GMT+02:00 Henri Verbeet <span dir="ltr"><<a href="mailto:hverbeet@gmail.com" target="_blank">hverbeet@gmail.com</a>></span>:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div class="">On 24 April 2014 12:10, Stefan Dösinger <<a href="mailto:stefan@codeweavers.com">stefan@codeweavers.com</a>> wrote:<br>

> -    if (!(surface->surface_desc.u4.ddpfPixelFormat.dwFlags & (DDPF_PALETTEINDEXED1 | DDPF_PALETTEINDEXED2<br>
> -            | DDPF_PALETTEINDEXED4 | DDPF_PALETTEINDEXED8 | DDPF_PALETTEINDEXEDTO8)))<br>
> -        return DDERR_INVALIDPIXELFORMAT;<br>
> -<br>
>      if (surface->surface_desc.ddsCaps.dwCaps2 & DDSCAPS2_MIPMAPSUBLEVEL)<br>
>          return DDERR_NOTONMIPMAPSUBLEVEL;<br>
><br>
</div>Note that this inverts the ordering of the pixel format and sub-level<br>
validation. That might even be correct, but the associated test<br>
doesn't cover that case at all.<br>
<br>
<br>
</blockquote></div><br></div>