<html>
<head>
<meta content="text/html; charset=ISO-8859-1"
http-equiv="Content-Type">
</head>
<body bgcolor="#FFFFFF" text="#000000">
<div class="moz-cite-prefix">Hi Zhenbo,<br>
<br>
On 05/23/14 14:20, Zhenbo Li wrote:<br>
</div>
<blockquote cite="mid:537F3D13.8050805@gmail.com" type="cite">
<div class="moz-text-plain" wrap="true" graphical-quote="true"
style="font-family: -moz-fixed; font-size: 12px;"
lang="x-western">
<pre wrap="">iff --git a/dlls/mshtml/htmltablerow.c b/dlls/mshtml/htmltablerow.c
index 731b403..f1b672b 100644
--- a/dlls/mshtml/htmltablerow.c
+++ b/dlls/mshtml/htmltablerow.c
@@ -308,8 +308,27 @@ static HRESULT WINAPI HTMLTableRow_get_cells(IHTMLTableRow *iface, IHTMLElementC
static HRESULT WINAPI HTMLTableRow_insertCell(IHTMLTableRow *iface, LONG index, IDispatch **row)
{
HTMLTableRow *This = impl_from_IHTMLTableRow(iface);
- FIXME("(%p)->(%d %p)\n", This, index, row);
- return E_NOTIMPL;
+ nsIDOMHTMLElement *nselem;
+ HTMLElement *elem = NULL;</pre>
</div>
</blockquote>
<br>
You shouldn't need to initialize it here.<br>
<br>
<blockquote cite="mid:537F3D13.8050805@gmail.com" type="cite">
<div class="moz-text-plain" wrap="true" graphical-quote="true"
style="font-family: -moz-fixed; font-size: 12px;"
lang="x-western">
<pre wrap="">
+ nsresult nsres;
+ HRESULT hres;
+
+ TRACE("(%p)->(%d %p)\n", This, index, row);
+ nsres = nsIDOMHTMLTableRowElement_InsertCell(This->nsrow, index, &nselem);
+ if(NS_FAILED(nsres)) {
+ ERR("Insert Cell at %d failed: %08x\n", index, nsres);
+ return E_FAIL;
+ }
+
+ hres = HTMLTableCell_Create(This->element.node.doc, nselem, &elem);
+ if (FAILED(hres)) {
+ ERR("Create TableCell failed: %08x\n", hres);
+ return hres;
+ }
+ nsIDOMHTMLElement_Release(nselem);</pre>
</div>
</blockquote>
<br>
There it a leak in error case. Move Release call before if
statement.<br>
<br>
<blockquote cite="mid:537F3D13.8050805@gmail.com" type="cite">
<div class="moz-text-plain" wrap="true" graphical-quote="true"
style="font-family: -moz-fixed; font-size: 12px;"
lang="x-western">
<pre wrap="">
+
+ hres = IHTMLElement_QueryInterface(&elem->IHTMLElement_iface, &IID_IDispatch, (void **)row);
+ return hres;</pre>
</div>
</blockquote>
<br>
You don't need QueryInterface here. Cast is fine as long as it's
done on an interface inheriting from IDispatch (but not on object,
as you did in previous version of the patch).<br>
<br>
Cheers,<br>
Jacek<br>
</body>
</html>