<html>
<head>
<meta http-equiv="content-type" content="text/html; charset=utf-8">
</head>
<body bgcolor="#FFFFFF" text="#000000">
<pre>Hi Nikolay,
On 12/29/2014 20:12, Nikolay Sivov wrote:
>On 30.12.2014 2:06, Sean Burke wrote:
>><i> Provides an implementation of time and date format functions added in
</i>>><i> Vista sufficient to allow some basic applications requiring them to run.
</i>>><i> Includes necessary tests and header defs.
</i>>><i>
</i>>><i>
</i>>><i> Sean Burke
</i>>><i>
</i>>><i>
</i>>><i>
</i>
>Hi, Sean.
>As you can see tests are failing on win2000 and winxp because these
>calls are not available on these platforms. You should use
>GetProcAddress() to fix that.
>><i> +@ stdcall GetDateFormatEx(ptr long ptr wstr ptr long ptr)
</i>
>First argument should be 'wstr' as well.
>><i> +@ stdcall GetTimeFormatEx(ptr long ptr wstr ptr long)
</i>
>Same.
>><i> +INT WINAPI GetDateFormatEx(LPCWSTR lpLocaleName, DWORD dwFlags,
</i>>><i> + const SYSTEMTIME* lpDate, LPCWSTR lpFormat,
</i>>><i> + LPWSTR lpDateStr, INT cchDate, LPCWSTR lpCalendar)
</i>
>Please use cleaner argument names, like 'localename', 'flags', 'date',
>'format', etc. So lowercase, no prefix.
The rest of the file uses argument names directly from the MSDN documentation. I'm inclined to follow this convention as I think it provides a clear and direct connection to the API as documented. However, I am unfamiliar with current wine conventions, so if you still feel this is a worthwhile change, let me know.
>><i> + lcid = LocaleNameToLCID(lpLocaleName, 0);
</i>>><i> +
</i>>><i> + return NLS_GetDateTimeFormatW(lcid, dwFlags | DATE_DATEVARSONLY, lpDate,
</i>>><i> + lpFormat, lpDateStr, cchDate);
</i>
>No real need for temporary 'lcid' variable.
Sean Burke
</pre>
</body>
</html>