<div dir="ltr"><div><div>Actually this patch fails windows tests. That means the return value is not right at D3DRM and D3DRMDevice, and I'm also getting wrong refcounts for all IDirect3DRMFrame{1-3} (after putting the correct return values).<br></div><br></div>I'll also keep the splitting up of files in mind as I write more tests in the future. :)<br></div><div class="gmail_extra"><br><div class="gmail_quote">On Sun, Mar 29, 2015 at 8:39 PM, Stefan Dösinger <span dir="ltr"><<a href="mailto:stefandoesinger@gmail.com" target="_blank">stefandoesinger@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">-----BEGIN PGP SIGNED MESSAGE-----<br>
Hash: SHA1<br>
<span class=""><br>
Am 2015-03-29 um 15:37 schrieb Aaryaman Vasishta:<br>
> +        { &IID_IDirect3DRM,                NULL,                   E_NOINTERFACE,       FALSE },<br>
</span>It's funny that this interface returns the right error value on QI.<br>
<span class=""><br>
> +    hr = IDirect3DRM_CreateFrame(d3drm3, NULL, &frame3);<br>
</span>Minor nitpick: IDirect3DRM3_CreateFrame . You can resend the patch with a fix if you want, but I'm OK with this patch as it is.<br>
<br>
Something to think about for future tests: It may make sense to split up d3drm.c into d3drm1.c, d3drm2.c and d3drm3.c for each interface version, similar to the ddraw tests.<br>
<br>
-----BEGIN PGP SIGNATURE-----<br>
Version: GnuPG v2<br>
<br>
iQIcBAEBAgAGBQJVGBWOAAoJEN0/YqbEcdMwLkUP/3S8gOP5XSYOgOkELFOSznNp<br>
ir09O5ef1HUpECpZjCks7ez4IbUhswcb/idJ3UeEx3lSBy4vIk3vY0usXcXKkfMl<br>
TlioDlOuzKhpXxb/5lZ/SUoG/nguBvzisKeifAA1gi8ne+3REhWeJvY6iBNDNDEX<br>
dNUYiTP+qxsq8c+bzgydxDuu0OT7LVEXrVrDO1g3qOebJjFSdkXOnf1bCntejX4S<br>
WdnxPlioWBMvffP42r0oinXzjoqobi5BDw8r4YppflEUou1bH3oT7fczJEpK4rBm<br>
2ZDz9EOhvMOa6M5PSiqwPpINfI1PpH+p9S0r3iMZz8ux2VbXDyfJ0i/5CdzQ3HX8<br>
rnNq/NcObXVgweBYIN7uFvjlo0Si963ACYDperAVyBNgP/oJXsz3dA5ysvrf6Lf8<br>
Xy1kdP2B79AxWR3DRumQS9sbruaofENF16/7d9MZE933uWY9xBS6JIKTP0AVdDsP<br>
tqF8ppHwVdPfpiazYnrG1ivpE0jNIPJJ67I6FWRC1S8k7QQVmbAdVnDgczDs6lLx<br>
hiZbjksd4Uf16oGO29bXeZ2YM3Zi75K9pCa7ruYoftcF2ihd0tU01+jbM6hY32qm<br>
K1RKe7/HCMANoal7pQEukARHVRvHDpVFRGJzeMbysc8yumnpbgl7/UI9z0wZvoYI<br>
aCAXfxi21aSdCzxC7mIU<br>
=9SMA<br>
-----END PGP SIGNATURE-----<br>
</blockquote></div><br></div>