<html>
<head>
<meta content="text/html; charset=utf-8" http-equiv="Content-Type">
</head>
<body bgcolor="#FFFFFF" text="#000000">
<div class="moz-cite-prefix">On 06/15/2015 06:31 PM, Jeremy White
wrote:<br>
</div>
<blockquote cite="mid:557EFDEF.4050502@codeweavers.com" type="cite">
<pre wrap=""><snip>
With that said, I think this is a hard problem; I think it boils down to
a request for Alexandre to be 'nicer', with varying shades of just what
that means, and it's been discussed enough through the years that it's
hard to discuss it constructively.
<snip>
</pre>
</blockquote>
Everyone seems to forget that Alexandre is doing *a lot*.<br>
The simple patch queue management is not an easy task.<br>
I guess he classifies patches, reads them, looks at bugzilla
entries, installs demo programs, tests patches, verifies them,
discusses with other developpers, waits for author feedback...<br>
Understanding the *real* issue is also complex. He needs to know
every windows component, how they are related..<br>
<br>
People just want their patch committed because
it-is-the-best-solution-ever but AJ has to keep the project moving
the right way, avoiding regressions...<br>
Let's imagine you're at the other side with a continuous flow of
patches...<br>
<br>
Yes, he has to make choices (rejecting patches...) and sometimes, we
don't get any input on what's wrong.<br>
But when he says 'doesn't compile here', it shows people don't even
test their stuff.<br>
Clearly, Alexandre is doing a lot and .. for years so be nice with
him ^^<br>
<br>
What are the issues here ?<br>
It seems people want feedback.<br>
What's wrong with my patch ? Why is it pending ? Is my patch
reviewed at all ? How to improve my patch, I'm a newbie...<br>
<br>
And why ?<br>
I guess AJ does too many things, lacks time and manpower.<br>
<br>
We can automate things:<br>
- compilation (done with testbot but not perfect yet)<br>
- formatting checks (spaces, if block on several lines or not...)<br>
- common issues (LPcrap...)<br>
<br>
I don't know how statuses are managed but maybe a tool can be
created or improved ?<br>
We can provide a mentor when a newbie posts a patch for the first
time so that AJ can do other things in the meantime. (or delegate to
wine-staging or a kind of sandbox but AJ doesn't like the idea)<br>
We could also use the 'sign-off' feature to <strike>delegate</strike>
make a patch verified by a trusted dev (= having a list with domain
<-> trusted dev).<br>
We can write standard commit rules and patch lifecycle rules so that
everyone know where their patch is far from commit.<br>
<br>
Any other thoughts ?<br>
</body>
</html>