<html>
<head>
<style><!--
.hmmessage P
{
margin:0px;
padding:0px
}
body.hmmessage
{
font-size: 12pt;
font-family:Calibri
}
--></style></head>
<body class='hmmessage'><div dir='ltr'>On Mon, 8 Feb 2016 22:12:05 +0900, Alexandre Julliard wrote:<br><div>> <br>> Hugh McMaster writes:<br>> <br>> > On Monday, 8 February 2016 20:06:55 +0900, Alexandre Julliard wrote:<br>> >> <br>> >> Hugh McMaster writes:<br>> >> <br>> >>> +static void __cdecl output_array(const WCHAR *fmt, ...)<br>> >>> +{<br>> >>> + __ms_va_list va_args;<br>> >>> +<br>> >>> + __ms_va_start(va_args, fmt);<br>> >>> + output_formatstring(fmt, va_args);<br>> >>> + __ms_va_end(va_args);<br>> >>> }<br>> >> <br>> >> That's a strange name, why "array"?<br>> ><br>> > Well, we use array syntax for string literals. So it's just for differentiating between string resources (as messages)<br>> > and string literals (as arrays).<br>> ><br>> > I also used the name in http://source.winehq.org/git/wine.git/commitdiff/4335c464c358d15024e76c918efb7721ff0d9cce<br>> > and it slipped past back then! :-)<br>> <br>> Right, I probably assumed that you meant the uninstalled programs array<br>> back then, not the string. Of course technically strings are also<br>> arrays, but that's a confusing name. Just name it output_string or<br>> something like that.<br><br>I considered output_string, but I thought it might cause confusion. Consider this:<br><br>output_message(STRING_INVALID_KEY); // message as resource string<br>output_string(pointer to some array of WCHAR, ...) // we pass in a pointer. Why don't we do output_string(STRING_INVALID_KEY)?<br><br>So the reference to a string in the function name and in the resource identifier could cause confusion because it looks as though<br>they should be related. Or that's my reading of it, at least.<br><br>Is either output_arraystr or output_strarray suitable?<br></div> </div></body>
</html>