<div dir="ltr">Right, makes sense. I will resend this patch with the changes today.<div>Fwiw, I've intentionally not added tests in patch 4/4 to validate the image struct in InitFromImage right now. I will include them in the implementation patch for this function. I'll be using a helper function which would validate the struct and return a BOOL, which would be re-used for CreateTexture as well.<br><div><br></div><div>Cheers,</div><div>Aaryaman</div></div><div class="gmail_extra"><br><div class="gmail_quote">On Mon, Apr 25, 2016 at 3:21 AM, Stefan Dösinger <span dir="ltr"><<a href="mailto:stefandoesinger@gmail.com" target="_blank">stefandoesinger@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><span>-----BEGIN PGP SIGNED MESSAGE-----<br>
Hash: SHA256<br>
<br>
<br>
</span><span>Am 2016-04-24 um 21:49 schrieb Aaryaman Vasishta:<br>
> My bad, that was a copy mistake. Will resend patch.<br>
</span>Even better than not checking would be to fill the array with some<br>
dummy value and checking that the content wasn't touched.<br>
<br>
I also recommend to re-order the tests so that failing tests are<br>
grouped together. That way you don't have to re-fill the array with a<br>
dummy value after a succeeding test.<br>
<br>
(try 2 sending this. Forgive me if it arrives twice)<br>
<span><br>
-----BEGIN PGP SIGNATURE-----<br>
Version: GnuPG v2<br>
<br>
</span>iQIcBAEBCAAGBQJXHT/uAAoJEN0/YqbEcdMwaXkP/iKRAq8nY5GxoETGm9pUZPML<br>
xFzwsmiRGidQv+TpXX3e5jAvgljxZMAVdlapZwQlvzdlZQxkjS5DcbcSAwrRDxHB<br>
QeRPaneMttPqYEQ7YCqpRt77/UNHtgTxjxF3RXMn1TIutnsTMiO6s4weyb0BbSdP<br>
PTdqyAnV9XFqmUZDVcHq/4pvoX/XEnrk5zxkv6+kJo5vqAYLMjRrB4Lu+g8oqgPE<br>
1polBPIcRluYX+VWFNHWVSwmBOlO6MMDa4JLj5WbN/m0i/XQOYD5JjcXeF5cxBwd<br>
jZ+8d2wvta8Sgl1oDKAGw+saHEKFBth9+zVa9AfcDUrNgsrq52DYneAXrGnsjfk3<br>
llL7Twz71eLtMo4YgRqLXLYxA5KCJSVvpwn8EaKBoCrUmv/pP/0j0MIZvMGXiQQG<br>
/acO/bC2EsgkLW69Tj4D4fymeJNJlk5sZf7QbeNCh61JPRlSZblsSJVt4DkiBG/l<br>
7CKZXqtHOZhfqa1MUGXxEajyv25KoUIcinPtKTFGAv2CLk1dm3hj3FteRJJ7M6Ag<br>
FTKN7k+67wJZUIrHLXYBWn1xjTmoYnbL5FHrDlGsEkTt655hEyhgzoL/e4XVnWdl<br>
Hh9F9ntrGN487AX6bD5zNMf0oBizVhDPyXzFHXIc/+pl3PYceexhXN0REJ61NAmJ<br>
qPqkXyPFigb34w/IzuVU<br>
=n5WM<br>
-----END PGP SIGNATURE-----<br>
</blockquote></div><br></div></div>