<div dir="ltr"><div><div>It actually sets them to NULL. I'll resend the patch including tests to account for this. I believe even LoadTexture would need similar tests as well.<br><br></div>Cheers,<br></div>Aaryaman<br></div><div class="gmail_extra"><br><div class="gmail_quote">On Mon, May 16, 2016 at 11:25 PM, Stefan Dösinger <span dir="ltr"><<a href="mailto:stefandoesinger@gmail.com" target="_blank">stefandoesinger@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">-----BEGIN PGP SIGNED MESSAGE-----<br>
Hash: SHA256<br>
<span class=""><br>
Am 2016-05-13 um 22:21 schrieb Aaryaman Vasishta:<br>
> -    *texture = &object->IDirect3DRMTexture3_iface;<br>
> +    if (FAILED(IDirect3DRMTexture3_InitFromImage(*texture, image)))<br>
> +    {<br>
> +        IDirect3DRMTexture3_Release(*texture);<br>
> +        return D3DRMERR_BADVALUE;<br>
> +    }<br>
</span>This will leave a non-NULL pointer stored in *texture, which is most likely wrong. Please extend your tests to check for this.<br>
<br>
-----BEGIN PGP SIGNATURE-----<br>
Version: GnuPG v2<br>
<br>
iQIcBAEBCAAGBQJXOgmWAAoJEN0/YqbEcdMw4PQP/1Ri28V/xXTb90aSLvHLi3QQ<br>
47cGk1M2C9/z3bj9kZUKfYGADCJVgdf52bcFQUb4yBBEkxtY2RrAYMAY2218l0PB<br>
QcNpkFhVEnauRII4CsoLShByEtKLfLo6sqflABUKoBfK9BELjz4QpDEUiMvyKHXk<br>
vRtesZBK16VaFnwbpQekFb233/sID9oCLitNzIXJ6ntNLEvGYCgfWmaT9VdXNGvv<br>
zvnQfWh8ayXbJGulUclNectDqA2ww+vRxHmC5dkgAVGHsfxOp1dY3Z45b6CNPksE<br>
iyxn6A3mAVgy6hhjbm8AjgN/8agkvwDRhL2774ZdemBCL1FAq39kFobSNju4evAx<br>
YH6r8bFiN1y3814hxMe74Zk2oXJsCN4ZL5ZxOOabJHdWHCxTDWU8yikordtlfdF2<br>
q1Va/GVi9aKLXiWhfNjusP5bG/DY8hK14dRe570eWP2U9fKbDaFLc8iVhwxZRs0N<br>
3EJddB286uvLjAGEbGEe5iSPTuTKCER0L/8rRTliczYt5rJeX+2955bTZu3ek5Uu<br>
XjmOzBP5374IiBDai1dhHX2EwTD3UxisN2olDUfFGee8DkDjzowKt5hFBYVT7x8j<br>
hDU7rkRKht2loO7vKEqX+uM9twplIWVIIcQWY2ZXT7gZ8x07bCqVa8eHhKy63cGp<br>
J1YMc8wPUUENq+iVYZ1W<br>
=sm0l<br>
-----END PGP SIGNATURE-----<br>
</blockquote></div><br></div>