<div dir="ltr">I made the changes to the patches we talked about and added the patch below. All it does is ignore "feature"-type elements which aren't meant for end user consumption, suppressing the FIXME message in Trace logs for those elements. Since these element types are un-handled by Winmm, I don't think a FIXME message is necessary for them. However, if you feel we should keep the fixme messages in place, I'm fine with that too. <div><br></div><div>Cheers,</div><div>David</div><div><br><div class="gmail_quote">---------- Forwarded message ----------<br>From: <b class="gmail_sendername">David Lawrie</b> <span dir="ltr"><<a href="mailto:david.dljunk@gmail.com">david.dljunk@gmail.com</a>></span><br>Date: Tue, Jun 14, 2016 at 8:33 PM<br>Subject: [v5 5/5] winejoystick.drv/joystick_osx.c: ignore feature elements<br>To: wine-patches <<a href="mailto:wine-patches@winehq.org">wine-patches@winehq.org</a>><br>Cc: David Lawrie <<a href="mailto:david.dljunk@gmail.com">david.dljunk@gmail.com</a>><br><br><br>"Describes input and output elements not intended for consumption by the<br>
end user."<br>
Ignore, as otherwise, comes up as a FIXME in Trace logs.<br>
<br>
Source:<br>
<a href="https://developer.apple.com/library/mac/documentation/IOKit/Reference/
IOHIDKeys_iokit_header_reference/#//apple_ref/c/tdef/IOHIDElementType" rel="noreferrer" target="_blank">https://developer.apple.com/library/mac/documentation/IOKit/Reference/<br>
IOHIDKeys_iokit_header_reference/#//apple_ref/c/tdef/IOHIDElementType</a><br>
<br>
Tested on OS X 10.10.5.<br>
<br>
Signed-off-by: David Lawrie <<a href="mailto:david.dljunk@gmail.com">david.dljunk@gmail.com</a>><br>
---<br>
 dlls/winejoystick.drv/joystick_osx.c | 3 +++<br>
 1 file changed, 3 insertions(+)<br>
<br>
diff --git a/dlls/winejoystick.drv/joystick_osx.c b/dlls/winejoystick.drv/joystick_osx.c<br>
index ad82dd7..12ccff7 100644<br>
--- a/dlls/winejoystick.drv/joystick_osx.c<br>
+++ b/dlls/winejoystick.drv/joystick_osx.c<br>
@@ -514,6 +514,9 @@ static void collect_joystick_elements(joystick_t* joystick, IOHIDElementRef coll<br>
                 }<br>
                 break;<br>
             }<br>
+            case kIOHIDElementTypeFeature:<br>
+                /* Describes input and output elements not intended for consumption by the end user. Ignoring. */<br>
+                break;<br>
             default:<br>
                 FIXME("Unhandled type %i\n",type);<br>
                 break;<br>
<span class="HOEnZb"><font color="#888888">--<br>
1.7.12.4 (Apple Git-37)<br>
<br>
</font></span></div><br></div></div>