<html><head><meta http-equiv="Content-Type" content="text/html charset=us-ascii"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;" class=""><div class="">OK. To answer your earlier question, anyway: yes, you would need to resubmit the whole series, even individual patches which didn't change. For those, you should mark them "resend" instead of bumping the version number.</div><div class=""><br class=""></div><div class="">I'm not entirely sure it was right of me to sign off on the one which was fine, since it wouldn't work without the earlier patch. I wanted to indicate that it was fine. That uncertainty is why I didn't do it for the other one. *shrug*</div><div class=""><br class=""></div><div class="">-Ken</div><br class=""><div><blockquote type="cite" class=""><div class="">On Jul 11, 2016, at 3:35 AM, DavidL <<a href="mailto:david.dljunk@gmail.com" class="">david.dljunk@gmail.com</a>> wrote:</div><br class="Apple-interchange-newline"><div class=""><div dir="ltr" class="">Actually it looks like I am going to make a slight change to device_location_comparator to get rid of another set of compilation warnings - I took a look at button_usage_comparator and modeled the new version after that which eliminated the warning messages.<div class=""><br class=""></div><div class="">Cheers,</div><div class="">David</div></div><div class="gmail_extra"><br class=""><div class="gmail_quote">On Sun, Jul 10, 2016 at 10:25 PM, DavidL <span dir="ltr" class=""><<a href="mailto:david.dljunk@gmail.com" target="_blank" class="">david.dljunk@gmail.com</a>></span> wrote:<br class=""><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr" class="">Hi Ken, <div class=""><br class=""></div><div class="">Thanks, I'll make the changes. For the dinput & winmm patch 2/3 & 2/2, should I resubmit them as part of my version 4 of the overall patches even if they have been signed-off on? (although I think only the dinput one was signed off on) I'm not anticipating making any changes to signed-off sorting code patch based on the comments.</div><div class=""><br class=""></div><div class="">Cheers,</div><div class="">David</div></div><div class="HOEnZb"><div class="h5"><div class="gmail_extra"><br class=""><div class="gmail_quote">On Sun, Jul 10, 2016 at 3:36 PM, Ken Thomases <span dir="ltr" class=""><<a href="mailto:ken@codeweavers.com" target="_blank" class="">ken@codeweavers.com</a>></span> wrote:<br class=""><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><span class="">On Jun 30, 2016, at 7:02 PM, David Lawrie <<a href="mailto:david.dljunk@gmail.com" target="_blank" class="">david.dljunk@gmail.com</a>> wrote:<br class="">
><br class="">
> Tested on OS X 10.10.5.<br class="">
><br class="">
> Signed-off-by: David Lawrie <<a href="mailto:david.dljunk@gmail.com" target="_blank" class="">david.dljunk@gmail.com</a>><br class="">
> ---<br class="">
> dlls/winejoystick.drv/joystick_osx.c | 30 ++++++++++++++++++++++++++++--<br class="">
> 1 file changed, 28 insertions(+), 2 deletions(-)<br class="">
<br class="">
</span>This has similar issues as the dinput version, the main one being the pointless "result" variable in get_device_property_long().<br class="">
<span class=""><font color="#888888" class=""><br class="">
-Ken<br class="">
<br class="">
</font></span></blockquote></div><br class=""></div>
</div></div></blockquote></div><br class=""></div>
</div></blockquote></div><br class=""></body></html>