<html><head><meta http-equiv="Content-Type" content="text/html; charset=UTF-8"></head><body >Thank you for your feedback.<div><div>WineD3D/D3D11/OpenGL are complex APIs with lots of tricky details.</div></div><div>I know my implementation is far from perfect, but it seems that you learn better by working, trying, so I do.</div><div>I have a basic but (likely) working tessellation implementation and I'll submit it soon. But it's quite dirty, so I expect feedbacks to improve it (if you haven't done it locally yet).</div><div><br></div><div>Btw, I think you should write down somewhere who is currently working on what at Crossover, to avoid useless duplicated work.</div><br><br><div>-------- Message d'origine --------</div><div>De : Józef Kucia <joseph.kucia@gmail.com> </div><div>Date :30/01/2017 14:13 (GMT+01:00) </div><div>À : wine-devel <wine-devel@winehq.org> </div><div>Cc : Guillaume Charifi <guillaume.charifi@sfr.fr> </div><div>Objet : Re: [PATCH 05/10] wined3d: Add compute shaders cb/samplers state
updates. </div><div><br></div>FWIW, I have a patch series adding basic support for compute shaders<br>in my patch queue. I should start submitting the series when my SM5<br>shader instructions series from wine-patches is committed.<br><br>I've skimmed over your patches though. I'll share some high-level comments.<br><br>On Sun, Jan 29, 2017 at 2:43 PM, Guillaume Charifi<br><guillaume.charifi@sfr.fr> wrote:<br>> Signed-off-by: Guillaume Charifi <guillaume.charifi@sfr.fr><br>> ---<br>> dlls/wined3d/context.c | 1 +<br>> dlls/wined3d/state.c | 3 +++<br>> 2 files changed, 4 insertions(+)<br>><br>> diff --git a/dlls/wined3d/context.c b/dlls/wined3d/context.c<br>> index ca73bcc..eaae0b8 100644<br>> --- a/dlls/wined3d/context.c<br>> +++ b/dlls/wined3d/context.c<br>> @@ -3382,6 +3382,7 @@ static void context_bind_shader_resources(struct wined3d_context *context, const<br>> {<br>> {WINED3D_SHADER_TYPE_PIXEL, 0, MAX_FRAGMENT_SAMPLERS},<br>> {WINED3D_SHADER_TYPE_VERTEX, MAX_FRAGMENT_SAMPLERS, MAX_VERTEX_SAMPLERS},<br>> + {WINED3D_SHADER_TYPE_COMPUTE, 0, MAX_COMPUTE_SAMPLERS},<br>> };<br><br>I don't think that adding a proper support for binding compute shader<br>resources is that simple.<br></body>