<div><br><div class="gmail_quote"><div>On Fri, Feb 24, 2017 at 1:32 PM Austin English <<a href="mailto:austinenglish@gmail.com">austinenglish@gmail.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">On Fri, Feb 24, 2017 at 12:26 PM, Chris Morgan <<a href="mailto:chmorgan@gmail.com" class="gmail_msg" target="_blank">chmorgan@gmail.com</a>> wrote:<br class="gmail_msg">
><br class="gmail_msg">
> On Fri, Feb 24, 2017 at 1:24 PM Austin English <<a href="mailto:austinenglish@gmail.com" class="gmail_msg" target="_blank">austinenglish@gmail.com</a>><br class="gmail_msg">
> wrote:<br class="gmail_msg">
>><br class="gmail_msg">
>> On Fri, Feb 24, 2017 at 6:53 AM, Chris Morgan <<a href="mailto:chmorgan@gmail.com" class="gmail_msg" target="_blank">chmorgan@gmail.com</a>> wrote:<br class="gmail_msg">
>> > On Fri, Feb 24, 2017 at 3:11 AM, Austin English<br class="gmail_msg">
>> > <<a href="mailto:austinenglish@gmail.com" class="gmail_msg" target="_blank">austinenglish@gmail.com</a>><br class="gmail_msg">
>> > wrote:<br class="gmail_msg">
>> >><br class="gmail_msg">
>> >> On Fri, Feb 24, 2017 at 2:05 AM, <<a href="mailto:wylda@volny.cz" class="gmail_msg" target="_blank">wylda@volny.cz</a>> wrote:<br class="gmail_msg">
>> >> > Hi,<br class="gmail_msg">
>> >> > i like/use "make -j 1" for log comparison. Can you leave NPROC=1 or<br class="gmail_msg">
>> >> > allow override?<br class="gmail_msg">
>> >> ><br class="gmail_msg">
>> >> > W.<br class="gmail_msg">
>> >> ><br class="gmail_msg">
>> >> ><br class="gmail_msg">
>> >><br class="gmail_msg">
>> >> Hi Wylda,<br class="gmail_msg">
>> >><br class="gmail_msg">
>> >> Are you doing that with wineinstall? This doesn't affect normal<br class="gmail_msg">
>> >> ./configure && make, only ./tools/wineinstall.<br class="gmail_msg">
>> >><br class="gmail_msg">
>> >> That said, allowing the user to set it via NPROC or similar would be a<br class="gmail_msg">
>> >> good idea IMO.<br class="gmail_msg">
>> >><br class="gmail_msg">
>> >> --<br class="gmail_msg">
>> >> -Austin<br class="gmail_msg">
>> >> GPG: 14FB D7EA A041 937B<br class="gmail_msg">
>> ><br class="gmail_msg">
>> ><br class="gmail_msg">
>> ><br class="gmail_msg">
>> ><br class="gmail_msg">
>> > Is this what you had in mind? I wasn't sure how to document that you<br class="gmail_msg">
>> > could<br class="gmail_msg">
>> > do:<br class="gmail_msg">
>> ><br class="gmail_msg">
>> > NPROC=50 ./tools/wineinstall<br class="gmail_msg">
>> ><br class="gmail_msg">
>> > to force 50 parallel processes.<br class="gmail_msg">
>> ><br class="gmail_msg">
>> ><br class="gmail_msg">
>> > commit 83321d6452706b5f8f93687ed4e0909aac47fd68<br class="gmail_msg">
>> > Author: Chris Morgan <<a href="mailto:chmorgan@gmail.com" class="gmail_msg" target="_blank">chmorgan@gmail.com</a>><br class="gmail_msg">
>> > Date: Tue Feb 21 17:03:30 2017 -0500<br class="gmail_msg">
>> ><br class="gmail_msg">
>> > wineinstall - Add support for parallel builds using 'nproc' to<br class="gmail_msg">
>> > detect<br class="gmail_msg">
>> > cpu count<br class="gmail_msg">
>> ><br class="gmail_msg">
>> > Parallel builds can greatly reduce the overall build time on modern<br class="gmail_msg">
>> > multi-core processors.<br class="gmail_msg">
>> ><br class="gmail_msg">
>> > Fall back to two parallel builds in the case where nproc is<br class="gmail_msg">
>> > unavailable,<br class="gmail_msg">
>> > most modern<br class="gmail_msg">
>> > processors have at least two cores.<br class="gmail_msg">
>> ><br class="gmail_msg">
>> > Use the 'NPROC' value defined by the environment if it is not null.<br class="gmail_msg">
>> ><br class="gmail_msg">
>> > diff --git a/tools/wineinstall b/tools/wineinstall<br class="gmail_msg">
>> > index e8e22bf..a757343 100755<br class="gmail_msg">
>> > --- a/tools/wineinstall<br class="gmail_msg">
>> > +++ b/tools/wineinstall<br class="gmail_msg">
>> > @@ -143,10 +143,22 @@ echo "in the meantime..."<br class="gmail_msg">
>> > echo<br class="gmail_msg">
>> > std_sleep<br class="gmail_msg">
>> ><br class="gmail_msg">
>> > +# determine ideal number of parallel processes if NPROC isn't set<br class="gmail_msg">
>> > +# in the environment<br class="gmail_msg">
>> > +if [ ! -n $NPROC ]<br class="gmail_msg">
>> > +then<br class="gmail_msg">
>> > + if [ -x `which nproc 2>/dev/null` ]<br class="gmail_msg">
>> > + then<br class="gmail_msg">
>> > + NPROC=$(nproc --all)<br class="gmail_msg">
>> > + else<br class="gmail_msg">
>> > + NPROC=2<br class="gmail_msg">
>> > + fi<br class="gmail_msg">
>> > +fi<br class="gmail_msg">
>> > +<br class="gmail_msg">
>> > # try to just make wine, if this fails 'make depend' and try to remake<br class="gmail_msg">
>> > -if ! { make; }<br class="gmail_msg">
>> > +if ! { make -j$NPROC; }<br class="gmail_msg">
>> > then<br class="gmail_msg">
>> > - if ! { make depend && make; }<br class="gmail_msg">
>> > + if ! { make depend && make -j$NPROC; }<br class="gmail_msg">
>> > then<br class="gmail_msg">
>> > echo<br class="gmail_msg">
>> > echo "Compilation failed, aborting install."<br class="gmail_msg">
>> ><br class="gmail_msg">
>><br class="gmail_msg">
>> Yeah, something like that (but please avoid the backticks).<br class="gmail_msg">
>><br class="gmail_msg">
>> --<br class="gmail_msg">
>> -Austin<br class="gmail_msg">
>> GPG: 14FB D7EA A041 937B<br class="gmail_msg">
><br class="gmail_msg">
><br class="gmail_msg">
> Hi Austin.<br class="gmail_msg">
><br class="gmail_msg">
> Can you clarify what you mean and comment on the documentation for how to<br class="gmail_msg">
> override nproc with the environment variable? I'd like to update and send<br class="gmail_msg">
> out a new patch.<br class="gmail_msg">
><br class="gmail_msg">
> Chris<br class="gmail_msg">
<br class="gmail_msg">
What you sent should work. Since nproc isn't always available, there's<br class="gmail_msg">
not a super clean way to do it, but a slightly cleaner alternative<br class="gmail_msg">
would be:<br class="gmail_msg">
<br class="gmail_msg">
if [ -x $(which nproc) ] ; then<br class="gmail_msg">
NPROC="${NPROC:-$(nproc --all)}"<br class="gmail_msg">
else<br class="gmail_msg">
NPROC="${NPROC:-2}"<br class="gmail_msg">
fi<br class="gmail_msg">
<br class="gmail_msg">
--<br class="gmail_msg">
-Austin<br class="gmail_msg">
GPG: 14FB D7EA A041 937B</blockquote><div><br></div><div><br></div><div>Ahh, that is simpler. I saw the conditional style when refreshing on tests and environment variables passed into scripts.</div><div><br></div><div>I also read that using type was preferred over which on a so post. I'm ok with either way though. I'll resend an updated patch.</div><div><br></div><div>Chris</div></div></div>