<div dir="ltr">Thanks again!</div><div class="gmail_extra"><br><div class="gmail_quote">2017-03-27 23:08 GMT+08:00 Andrew Eikum <span dir="ltr"><<a href="mailto:aeikum@codeweavers.com" target="_blank">aeikum@codeweavers.com</a>></span>:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Thanks, just a couple more tweaks.<br>
<br>
On Mon, Mar 27, 2017 at 10:57:36PM +0800, Jactry Zeng wrote:<br>
> diff --git a/dlls/devenum/tests/devenum.c b/dlls/devenum/tests/devenum.c<br>
> index e3c0f47256..b6275be8d2 100644<br>
> --- a/dlls/devenum/tests/devenum.c<br>
> +++ b/dlls/devenum/tests/devenum.c<br>
> @@ -135,6 +135,94 @@ static void test_devenum(IBindCtx *bind_ctx)<br>
>      if(sizeof(void*) == 4)<br>
>          ok(have_mrle, "mrle codec not found\n");<br>
>  }<br>
> +static void test_moniker_isequal(void)<br>
> +{<br>
> +    HRESULT res;<br>
> +    ICreateDevEnum *create_devenum = NULL;<br>
> +    IEnumMoniker *enum_moniker0 = NULL, *enum_moniker1 = NULL;<br>
> +    IMoniker *moniker0 = NULL, *moniker1 = NULL;<br>
> +<br>
> +    res = CoCreateInstance(&CLSID_<wbr>SystemDeviceEnum, NULL, CLSCTX_INPROC,<br>
> +                           &IID_ICreateDevEnum, (LPVOID*)&create_devenum);<br>
> +    if (res)<br>
<br>
Please use FAILED() here.<br>
<br>
> +         if (SUCCEEDED(IEnumMoniker_Next(<wbr>enum_moniker0, 1, &moniker0, NULL)) &&<br>
> +             SUCCEEDED(IEnumMoniker_Next(<wbr>enum_moniker1, 1, &moniker1, NULL)))<br>
> +        {<br>
> +            res = IMoniker_IsEqual(moniker0, moniker1);<br>
> +            ok(SUCCEEDED(res), "IMoniker_IsEqual failed (res = %x)\n", res);<br>
> +<br>
> +            res = IMoniker_IsEqual(moniker1, moniker0);<br>
> +            ok(SUCCEEDED(res), "IMoniker_IsEqual failed (res = %x)\n", res);<br>
<br>
These should be compared against S_OK, otherwise S_FALSE will also<br>
pass the test.<br>
<span class="HOEnZb"><font color="#888888"><br>
Andrew<br>
<br>
<br>
</font></span></blockquote></div><br><br clear="all"><div><br></div>-- <br><div class="gmail_signature" data-smartmail="gmail_signature"><div dir="ltr"><div>Regards,<br></div><div>Jactry Zeng</div><div><br></div></div></div>
</div>