<html>
  <head>
    <meta http-equiv="Content-Type" content="text/html; charset=utf-8">
  </head>
  <body text="#000000" bgcolor="#FFFFFF">
    <p><tt>Hi Carlos,</tt></p>
    <p><tt>You </tt><tt>submitted a patch with conf</tt><tt>l</tt><tt>icts
        un</tt><tt>res</tt><tt>olved. Pl</tt><tt>ease reso</tt><tt>l</tt><tt>ve</tt><tt>
        t</tt><tt>hem </tt><tt>before submitting.</tt><tt><br>
      </tt></p>
    <tt></tt>
    <blockquote type="cite"><tt>Re: [PATCH 2/2] Test for explorer.exe
        with Bugs fixed</tt></blockquote>
    <tt>If this is the 2/2 patch, I don't see the 1/2. And the naming
      scheme should be "explorer/tests: message".<br>
      See git log for examples.<br>
      <blockquote type="cite">
        <pre wrap="">LPDWORD lpExitCode;</pre>
      </blockquote>
      underscore is preferred over camel case.<br>
      <blockquote type="cite">
        <pre wrap="">char cmd[] = {'e','x','p','l','o','r','e','r',' ','C',':',92,'w','i','n','d','o','w','s',0};</pre>
      </blockquote>
      I believe 92 is a ascii character, so why don't you use human
      readable form instead.<br>
      <br>
      Here's my personal checklist for sending patches. Hope it would be
      of help to you.<br>
      <br>
      # Send patch checklist<br>
      pull master and rebase<br>
      check compile warnings<br>
      check test coverage<br>
      git-clang-format --diff -f and then </tt><tt><tt>git-clang-format
        -f<br>
        # static analyze<br>
      </tt>cppcheck --enable=all [your code]<br>
      make clean && scan-build --show-description
      --show-description make -j4<br>
      testbot<br>
      final check line by line.<br>
      <br>
      I know you are trying to get in GSoC. Please be patient and work
      on your patches because Alexandre has high standards of them.<br>
      <br>
      Best Wishes,<br>
      Zhiyi Zhang<br>
    </tt><br>
    <tt><u><a moz-do-not-send="true"
          href="https://wiki.winehq.org/Code_Coverage">https://wiki.winehq.org/Code_Coverage</a><br>
        <a moz-do-not-send="true" href="https://testbot.winehq.org/">https://testbot.winehq.org/</a><br>
        <a moz-do-not-send="true"
          href="https://source.winehq.org/git/wine.git/shortlog?pg=1">https://source.winehq.org/git/wine.git/shortlog?pg=1</a><br>
      </u></tt><tt><a moz-do-not-send="true"
        href="https://wiki.winehq.org/Submitting_Patches">https://wiki.winehq.org/Submitting_Patches</a></tt><br>
    <br>
    <div class="moz-cite-prefix">On Fri 3 23 8:06, Carlos Vega GarcĂ­a
      wrote:<br>
    </div>
    <blockquote type="cite"
      cite="mid:1521763585-8260-2-git-send-email-carlosvegagc@gmail.com">
      <pre wrap="">---
 programs/explorer/tests/explorer.c | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/programs/explorer/tests/explorer.c b/programs/explorer/tests/explorer.c
index 28e1ad3..032ef6f 100755
--- a/programs/explorer/tests/explorer.c
+++ b/programs/explorer/tests/explorer.c
@@ -132,8 +132,13 @@ int explorer_available(void)
        STARTUPINFOA si;
        PROCESS_INFORMATION pi;
        LPDWORD lpExitCode;
+<<<<<<< HEAD
        char cmd[] = {'e','x','p','l','o','r','e','r',' ','/','r','o','o','t',0};
        char windowName[] = {'r','o','o','t',0};
+=======
+       char cmd[] = {'e','x','p','l','o','r','e','r',' ','C',':',92,'w','i','n','d','o','w','s',0};
+       char windowName[] = {'w','i','n','d','o','w','s',0};
+>>>>>>> b2b5eab... Test for explorer with Bugs fixed
 
        memset(&si, 0, sizeof(si));
        si.cb = sizeof(si);
</pre>
    </blockquote>
    <br>
  </body>
</html>