<div dir="ltr">Hi,<br><br>Thanks for the patch!<br><br>You might want to submit it as per the guidelines mentioned here <a href="https://wiki.winehq.org/Submitting_Patches">https://wiki.winehq.org/Submitting_Patches</a>.<br><br>Cheers,<div>Aaryaman</div></div><div class="gmail_extra"><br><div class="gmail_quote">On Mon, Mar 26, 2018 at 8:07 PM, Gero Zahn <span dir="ltr"><<a href="mailto:geroz@gmx.de" target="_blank">geroz@gmx.de</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Hi,<br>
<br>
I submitted a pull-request over at<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<a href="https://github.com/wine-mirror/wine/pull/9" rel="noreferrer" target="_blank">https://github.com/wine-mirror<wbr>/wine/pull/9</a><br>
</blockquote>
and @AndreRH was so kind as to inform me that it wouldn't be picked up over there. ;-)<br>
<br>
So, here goes: I'm using wine on macOS with a regular PC keyboard. When using Windows applications, I miss support for the right popup menu key -- that's not the right Windows / Command key, but actually VK_APPS.<br>
<br>
I've been patching <a href="http://winemac.drv.so" rel="noreferrer" target="_blank">winemac.drv.so</a> via hex editor manually for quite a while to enable support for this key. Now I thought that I might contribute this otherwise harmless improvement back to the source code.<br>
<br>
... I have to admit that I didn't compile the patch myself. :-( But I am convinced that my modification to the source should result in the desired functionality.<br>
<br>
Here's the (minuscule) patch to keyboard.c -- if the format shouldn't suffice, you can find everything else in above mentioned wine-mirror link at<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<a href="https://github.com/wine-mirror/wine/pull/9/files" rel="noreferrer" target="_blank">https://github.com/wine-mirror<wbr>/wine/pull/9/files</a><br>
</blockquote>
<br>
 ---------->8 snip<br>
<br>
$ diff keyboard_orig.c keyboard_patched.c<br>
161a162<br>
>     kVK_APPS                = 0x6E,<br>
297c298<br>
<     { 0,                        0,              FALSE },    /* 0x6E unused */<br>
---<br>
>     { VK_APPS,                  0x6E,           TRUE },     /* kVK_APPS */<br>
395a397<br>
>     { VK_APPS,                  "Apps" },<br>
$<br>
<br>
<br>
</blockquote></div><br></div>