<div dir="ltr"><div><div><div>With a bit of searching i found the following below*** makes the tests pass on 64-bit testbots.<br></div>I`ll send tests for review then, but note that there are still 12 failures in win2003, but they also appear when you send a NOOP to testbot like here below *****.<br></div>So I guess that`s not due to the test i added.<br><br><br></div>*****: this causes 12 failures on win2003:<br>diff --git a/dlls/shell32/tests/shlfolder.c b/dlls/shell32/tests/shlfolder.c<br>index c976c85..aba60d0 100644<br>--- a/dlls/shell32/tests/shlfolder.c<br>+++ b/dlls/shell32/tests/shlfolder.c<br>@@ -3944,7 +3944,7 @@ static void test_ShellItemBindToHandler(void)<br> <br>             /* BHID_Stream */<br>             hr = IShellItem_BindToHandler(psi, NULL, &BHID_Stream, &IID_IStream, (void**)&punk);<br>-            ok(hr == E_NOINTERFACE, "Got 0x%08x\n", hr);<br>+            ok(hr == E_NOINTERFACE, "Got test 0x%08x\n", hr);<br>             if(SUCCEEDED(hr)) IUnknown_Release(punk);<br>             hr = IShellItem_BindToHandler(psi, NULL, &BHID_Stream, &IID_IUnknown, (void**)&punk);<br>             ok(hr == S_OK, "Got 0x%08x\n", hr);<br><br><br><div><br><br></div><div>***:this makes test pass on 64bot<br></div><div>diff --git a/include/shlobj.h b/include/shlobj.h<br>index 9d6dcdd..d66e0eb 100644<br>--- a/include/shlobj.h<br>+++ b/include/shlobj.h<br>@@ -1472,6 +1472,8 @@ int WINAPI SHCreateDirectoryExA(HWND, LPCSTR, LPSECURITY_ATTRIBUTES);<br> int WINAPI SHCreateDirectoryExW(HWND, LPCWSTR, LPSECURITY_ATTRIBUTES);<br> #define    SHCreateDirectoryEx WINELIB_NAME_AW(SHCreateDirectoryEx)<br> <br>+#include <pshpack8.h><br>+<br> /****************************************************************************<br> * SHGetSetFolderCustomSettings API<br> */<br>@@ -1510,6 +1512,7 @@ typedef struct {<br> <br> HRESULT WINAPI SHGetSetFolderCustomSettings(LPSHFOLDERCUSTOMSETTINGS pfcs, PCWSTR pszPath, DWORD dwReadWrite);<br> <br>+#include <poppack.h><br> /****************************************************************************<br> * SHGetSpecialFolderLocation API<br> */<br></div></div><div class="gmail_extra"><br><div class="gmail_quote">2018-04-20 9:06 GMT+02:00 Alexandre Julliard <span dir="ltr"><<a href="mailto:julliard@winehq.org" target="_blank">julliard@winehq.org</a>></span>:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><span class="">Louis Lenders <<a href="mailto:xerox.xerox2000x@gmail.com">xerox.xerox2000x@gmail.com</a>> writes:<br>
<br>
> v2: -fixed a misleading comment<br>
>     - only print fixme when needed<br>
><br>
> This fixes bug <a href="https://bugs.winehq.org/show_bug.cgi?id=44959" rel="noreferrer" target="_blank">https://bugs.winehq.org/show_<wbr>bug.cgi?id=44959</a><br>
><br>
> I also tried to write a test, that test passes on the 32-bit testbots, but somehow the last test fails on 64-bit testbots and i don`t know why.<br>
> Test is at <a href="https://testbot.winehq.org/GetFile.pl?JobKey=37794&StepKey=1" rel="noreferrer" target="_blank">https://testbot.winehq.org/<wbr>GetFile.pl?JobKey=37794&<wbr>StepKey=1</a><br>
<br>
</span>Probably the structure is using the wrong packing for 64-bit.<br>
<span class="HOEnZb"><font color="#888888"><br>
-- <br>
Alexandre Julliard<br>
<a href="mailto:julliard@winehq.org">julliard@winehq.org</a><br>
</font></span></blockquote></div><br></div>