<html><head></head><body>It looks to me like Elite is doing exactly what is described in your link - so that change fixes my problem. So I'm happy to ditch this patch in favour of that.<br><br><div class="gmail_quote">On 21 November 2018 12:56:31 am AEDT, Andrew Eikum <aeikum@codeweavers.com> wrote:<blockquote class="gmail_quote" style="margin: 0pt 0pt 0pt 0.8ex; border-left: 1px solid rgb(204, 204, 204); padding-left: 1ex;">
<pre class="k9mail">On Tue, Nov 20, 2018 at 12:53:21PM +1100, Brendan McGrath wrote:<br><blockquote class="gmail_quote" style="margin: 0pt 0pt 1ex 0.8ex; border-left: 1px solid #729fcf; padding-left: 1ex;">Here's the commit from Proton that removed the masquerade. Native xinput<br>wasn't something I had thought of. That could be why it's there.<br><br></blockquote><br>Oh yeah, I remember that now. I wonder if the right answer isn't just<br>to apply that same change to Wine.<br><br>Andrew<br><br><blockquote class="gmail_quote" style="margin: 0pt 0pt 1ex 0.8ex; border-left: 1px solid #729fcf; padding-left: 1ex;">commit 4d49baf4566d8343055424467bad5e2958390103<br>Author: Andrew Eikum <aeikum@codeweavers.com><br>Date: Fri Aug 3 12:36:21 2018 -0500<br><br> winebus: Don't override real VID/PID for controllers<br><br> It's unclear what this was useful for, possibly native xinput requires<br> it. Our built-in xinput is good enough now, though, so let's keep the<br> real VID/PID. This lets applications match setupapi devices with dinput<br> devices, see:<br><br> "XInput and DirectInput"<br><a href="https://docs.microsoft.com/en-us/windows/desktop/xinput/xinput-and-directinput">https://docs.microsoft.com/en-us/windows/desktop/xinput/xinput-and-directinput</a><br><br>On 20/11/18 12:37 pm, Brendan McGrath wrote:<br><blockquote class="gmail_quote" style="margin: 0pt 0pt 1ex 0.8ex; border-left: 1px solid #ad7fa8; padding-left: 1ex;">I'm not a fan of the registry hack either - it should be plug and play.<br><br>To match Windows functionality would be to remove the masquerade (as<br>Proton has). That would fix my problem - but potentially create an issue<br>for other games that are dependant on this masquerade (although I'm not<br>familiar with the reasons behind its inclusion).<br><br>Perhaps a compromise is to keep this registry hack but have it default<br>to use the real VID and PID. Then it matches Windows but there is still<br>an option for those who need the masquerade (and they can choose the<br>device to which they masquerade).<br><br>On 20/11/18 12:17 pm, Zebediah Figura wrote:<br><blockquote class="gmail_quote" style="margin: 0pt 0pt 1ex 0.8ex; border-left: 1px solid #8ae234; padding-left: 1ex;"><br>Be that as it may, I'm not sure that a registry hack is the approach<br>we want to take. If the game doesn't work with controllers that<br>don't report themselves as gamepads, but should, then we should fix<br>it to work.<br><br>At the same time, as regards your original problem, we should look<br>to rewrite the dinput joystick code on top of Wine's HID stack, so<br>that it will report the same VID/PID as xinput does. I believe Aric<br>is working on some patches to this effect ;-)<br><br><br></blockquote><br><br></blockquote><br><br></blockquote></pre></blockquote></div><br>-- <br>Sent from my Android device with K-9 Mail. Please excuse my brevity.</body></html>