<div dir="auto"><div><br><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Sun, 7 Apr 2019, 12:42 am Alexandre Julliard, <<a href="mailto:julliard@winehq.org">julliard@winehq.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Isira Seneviratne <<a href="mailto:isirasen96@gmail.com" target="_blank" rel="noreferrer">isirasen96@gmail.com</a>> writes:<br>
<br>
> @@ -60,33 +61,48 @@ static WCHAR wszIOWriteBytes[255];<br>
>  static WCHAR wszIOOtherBytes[255];<br>
>  /* Column Headers; End */<br>
>  <br>
> +const int ColumnSizeArrayValues[] = { 105, 50, 107, 70, 35, 70, 70, 100, 70, 70, 70, 70,<br>
> +                                      70, 70, 60, 60, 60, 60, 60, 70, 70, 70, 70, 70, 70 };<br>
> +<br>
> +static WCHAR *wszPointers[] = { wszImageName, wszPID, wszUserName, wszSessionID, wszCPU, wszCPUTime,<br>
> +                                wszMemUsage, wszPeakMemUsage, wszMemDelta, wszPageFaults, wszPFDelta,<br>
> +                                wszVMSize, wszPagedPool, wszNPPool, wszBasePri, wszHandles, wszThreads,<br>
> +                                wszUSERObjects, wszGDIObjects, wszIOReads, wszIOWrites, wszIOOther,<br>
> +                                wszIOReadBytes, wszIOWriteBytes, wszIOOtherBytes };<br>
> +<br>
> +static const int IDSValues[] = { IDS_IMAGENAME, IDS_PID, IDS_USERNAME, IDS_SESSIONID, IDS_CPUUSAGE, IDS_CPUTIME,<br>
> +                                 IDS_MEMORYUSAGE, IDS_PEAKMEMORYUSAGE, IDS_MEMORYUSAGEDELTA, IDS_PAGEFAULTS,<br>
> +                                 IDS_PAGEFAULTSDELTA, IDS_VIRTUALMEMORYSIZE, IDS_PAGEDPOOL, IDS_NONPAGEDPOOL,<br>
> +                                 IDS_BASEPRIORITY, IDS_HANDLECOUNT, IDS_THREADCOUNT, IDS_USEROBJECTS, IDS_GDIOBJECTS,<br>
> +                                 IDS_IOREADS, IDS_IOWRITES, IDS_IOOTHER, IDS_IOREADBYTES, IDS_IOWRITEBYTES,<br>
> +                                 IDS_IOOTHERBYTES };<br>
> +<br>
> +static const int IDCValues[] = { IDC_IMAGENAME, IDC_PID, IDC_USERNAME, IDC_SESSIONID, IDC_CPUUSAGE, IDC_CPUTIME,<br>
> +                                 IDC_MEMORYUSAGE, IDC_PEAKMEMORYUSAGE, IDC_MEMORYUSAGEDELTA, IDC_PAGEFAULTS,<br>
> +                                 IDC_PAGEFAULTSDELTA, IDC_VIRTUALMEMORYSIZE, IDC_PAGEDPOOL, IDC_NONPAGEDPOOL,<br>
> +                                 IDC_BASEPRIORITY, IDC_HANDLECOUNT, IDC_THREADCOUNT, IDC_USEROBJECTS, IDC_GDIOBJECTS,<br>
> +                                 IDC_IOREADS, IDC_IOWRITES, IDC_IOOTHER, IDC_IOREADBYTES, IDC_IOWRITEBYTES,<br>
> +                                 IDC_IOOTHERBYTES };<br>
> +<br>
> +static BOOL *SettingsBoolPtrs[] = { &TaskManagerSettings.Column_ImageName, &TaskManagerSettings.Column_PID,<br>
> +                                    &TaskManagerSettings.Column_UserName, &TaskManagerSettings.Column_SessionID,<br>
> +                                    &TaskManagerSettings.Column_CPUUsage, &TaskManagerSettings.Column_CPUTime,<br>
> +                                    &TaskManagerSettings.Column_MemoryUsage, &TaskManagerSettings.Column_PeakMemoryUsage,<br>
> +                                    &TaskManagerSettings.Column_MemoryUsageDelta, &TaskManagerSettings.Column_PageFaults,<br>
> +                                    &TaskManagerSettings.Column_PageFaultsDelta, &TaskManagerSettings.Column_VirtualMemorySize,<br>
> +                                    &TaskManagerSettings.Column_PagedPool, &TaskManagerSettings.Column_NonPagedPool,<br>
> +                                    &TaskManagerSettings.Column_BasePriority, &TaskManagerSettings.Column_HandleCount,<br>
> +                                    &TaskManagerSettings.Column_ThreadCount, &TaskManagerSettings.Column_USERObjects,<br>
> +                                    &TaskManagerSettings.Column_GDIObjects, &TaskManagerSettings.Column_IOReads,<br>
> +                                    &TaskManagerSettings.Column_IOWrites, &TaskManagerSettings.Column_IOOther,<br>
> +                                    &TaskManagerSettings.Column_IOReadBytes, &TaskManagerSettings.Column_IOWriteBytes,<br>
> +                                    &TaskManagerSettings.Column_IOOtherBytes };<br>
<br>
That's not really better either. All these things should be arrays, with<br>
a global enum to assign names to array entries.<br>
<br>
-- <br>
Alexandre Julliard<br>
<a href="mailto:julliard@winehq.org" target="_blank" rel="noreferrer">julliard@winehq.org</a></blockquote></div></div><div dir="auto"><br></div><div dir="auto">So should TASKMANAGER_SETTINGS be rewritten to include a BOOL array?</div><div dir="auto"><div class="gmail_quote"><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><br>
</blockquote></div></div></div>