<div dir="ltr">Thank you for all these reviews. I have submitted v4 to rebase on master and fix whitespace issues. I'll address all your issues in v5.<br></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Thu, Apr 11, 2019 at 3:35 PM Jacek Caban <<a href="mailto:jacek@codeweavers.com">jacek@codeweavers.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">On 4/11/19 8:26 PM, Derek Lesho wrote:<br>
> @@ -3431,7 +3433,8 @@ void WINAPI ExReleaseResourceForThreadLite( PERESOURCE resource, ERESOURCE_THREA<br>
> */<br>
> void WINAPI KeEnterCriticalRegion(void)<br>
> {<br>
> - FIXME(": stub\n");<br>
> + TRACE(": semi-stub\n");<br>
> + KeGetCurrentThread()->critical_region = TRUE;<br>
> }<br>
<br>
<br>
According to MSDN, those may be called recursively, so you'd need a <br>
counter here instead.<br>
<br>
<br>
Thanks,<br>
<br>
Jacek<br>
<br>
</blockquote></div>