<div dir="ltr"><div dir="ltr"><div dir="ltr"><br></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Sat, Apr 20, 2019 at 7:07 PM Zebediah Figura <<a href="mailto:z.figura12@gmail.com">z.figura12@gmail.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">Signed-off-by: Zebediah Figura <<a href="mailto:z.figura12@gmail.com" target="_blank">z.figura12@gmail.com</a>><br>
---<br>
 dlls/devenum/createdevenum.c | 2 +-<br>
 1 file changed, 1 insertion(+), 1 deletion(-)<br>
<br>
diff --git a/dlls/devenum/createdevenum.c b/dlls/devenum/createdevenum.c<br>
index 2db5491190..b89cac6d39 100644<br>
--- a/dlls/devenum/createdevenum.c<br>
+++ b/dlls/devenum/createdevenum.c<br>
@@ -795,7 +795,7 @@ static void register_avicap_devices(void)<br>
<br>
         friendlyname[5] = '0' + i;<br>
<br>
-        hr = register_codec(&CLSID_VideoInputDeviceCategory, name,<br>
+        hr = register_codec(&CLSID_VideoInputDeviceCategory, friendlyname,<br>
                 &CLSID_VfwCapture, friendlyname, &prop_bag);<br>
         if (FAILED(hr))<br>
             continue;<br>
-- <br>
2.21.0<br>
<br>
<br></blockquote><div><br></div><div><br></div><div></div><div>Currently the "name" is the device description, eg. "KWorld Webcam V2010   : KWorld ".</div><div>The "friendlyname" is "video0", "video1".<br></div><div>Shouldn't it be the other way around?<br></div><div><br></div><div>Also instead of passing friendlyname twice to register_codec(), shouldn't we pass them both but in opposite order?</div><div><br></div><div>Just a thought.<br></div><div><br></div></div></div></div>