<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=UTF-8">
</head>
<body text="#000000" bgcolor="#FFFFFF">
On 16-06-19 08:49, Alistair Leslie-Hughes wrote:<br>
<blockquote type="cite"
cite="mid:PSXP216MB06323095B3DD5B0C3BF7B9C193E80@PSXP216MB0632.KORP216.PROD.OUTLOOK.COM">
<pre class="moz-quote-pre" wrap="">Signed-off-by: Alistair Leslie-Hughes <a class="moz-txt-link-rfc2396E" href="mailto:leslie_alistair@hotmail.com"><leslie_alistair@hotmail.com></a>
---
dlls/dpnet/peer.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/dlls/dpnet/peer.c b/dlls/dpnet/peer.c
index f935b2a313..3df07749c5 100644
--- a/dlls/dpnet/peer.c
+++ b/dlls/dpnet/peer.c
@@ -157,6 +157,7 @@ HRESULT enum_services_providers(const GUID * const service, DPN_SERVICE_PROVIDER
next_key = RegEnumKeyW( key, index, provider, MAX_PATH);
while(next_key == ERROR_SUCCESS)
{
+ size = 0;
res = RegGetValueW(key, provider, friendly, RRF_RT_REG_SZ, NULL, NULL, &size);
if(res == ERROR_SUCCESS)
{
</pre>
</blockquote>
Wouldn't it be more correct to fix RegGetValueW to do<br>
<br>
<span id="xref-L-7195489-3205-1" class="xref xref-L-7195489-521
xref-defn">cbData</span> = <span id="xref-L-7195489-3335-2"
class="xref xref-L-7195489-519">(pcbData</span> && pvData)
? *<span id="xref-L-7195489-3605-2" class="xref xref-L-7195489-519">pcbData</span> : <span
class="literal">0</span>;<br>
<br>
instead of<br>
<br>
<span id="xref-L-7195489-3205-1" class="xref xref-L-7195489-521
xref-defn">cbData</span> = <span id="xref-L-7195489-3335-2"
class="xref xref-L-7195489-519">pcbData</span> ? *<span
id="xref-L-7195489-3605-2" class="xref xref-L-7195489-519">pcbData</span> : <span
class="literal">0</span>;<br>
<br>
instead? <span id="xref-1661159358-7-1" class="xref xref-436303546
xref-436303546 xref-defn">RegQueryValueExW does something similar.</span>
</body>
</html>