<div dir="ltr"><div>Hi Philip,</div><div><br></div><div>This causes a crash in the vkd3d tests, after line 28451 in tests/d3d12.c, when combined with only the preceding patch or the complete set.<br></div><div>libs/vkd3d-shader/spirv.c:1638: vkd3d_spirv_get_type_id: Assertion `component_type != VKD3D_TYPE_VOID' failed.</div></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Thu, Oct 17, 2019 at 6:36 AM Philip Rebohle <<a href="mailto:philip.rebohle@tu-dortmund.de">philip.rebohle@tu-dortmund.de</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">Signed-off-by: Philip Rebohle <<a href="mailto:philip.rebohle@tu-dortmund.de" target="_blank">philip.rebohle@tu-dortmund.de</a>><br>
---<br>
 libs/vkd3d-shader/spirv.c | 6 +++---<br>
 1 file changed, 3 insertions(+), 3 deletions(-)<br>
<br>
diff --git a/libs/vkd3d-shader/spirv.c b/libs/vkd3d-shader/spirv.c<br>
index 1598ae0..9b8da57 100644<br>
--- a/libs/vkd3d-shader/spirv.c<br>
+++ b/libs/vkd3d-shader/spirv.c<br>
@@ -4381,10 +4381,10 @@ static void vkd3d_dxbc_compiler_emit_output(struct vkd3d_dxbc_compiler *compiler<br>
             vkd3d_spirv_build_op_decorate(builder, id, SpvDecorationPatch, NULL, 0);<br>
<br>
         vkd3d_dxbc_compiler_decorate_xfb_output(compiler, id, output_component_count, signature_element);<br>
-    }<br>
<br>
-    compiler->output_info[signature_idx].id = id;<br>
-    compiler->output_info[signature_idx].component_type = component_type;<br>
+        compiler->output_info[signature_idx].id = id;<br>
+        compiler->output_info[signature_idx].component_type = component_type;<br>
+    }<br>
<br>
     if (use_private_variable)<br>
         storage_class = SpvStorageClassPrivate;<br>
-- <br>
2.23.0<br>
<br>
<br>
</blockquote></div>