<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=UTF-8">
</head>
<body text="#000000" bgcolor="#FFFFFF">
<p><br>
</p>
<div class="moz-cite-prefix">On 25/10/2019 17:37, Michael Stefaniuc
wrote:<br>
</div>
<blockquote type="cite"
cite="mid:6983748a-5024-029c-3003-1dbd58bece0e@winehq.org">
<pre class="moz-quote-pre" wrap="">On 10/25/19 5:10 AM, Alistair Leslie-Hughes wrote:
</pre>
<blockquote type="cite" style="color: #000000;">
<pre class="moz-quote-pre" wrap="">Signed-off-by: Alistair Leslie-Hughes <a class="moz-txt-link-rfc2396E" href="mailto:leslie_alistair@hotmail.com" moz-do-not-send="true"><leslie_alistair@hotmail.com></a>
---
Remove IID_IClassFactory checks
</pre>
</blockquote>
<pre class="moz-quote-pre" wrap="">I see some DLLs do something like this
*ppv = NULL;
if (!IsEqualIID(iid, &IID_IUnknown) && !IsEqualIID(iid,
&IID_IClassFactory))
return E_NOINTERFACE;
The only test I could find for this is in propset_private_tests() in
dlls/dsound/tests/propset.c .
And that seems to confirm the E_NOINTERFACE return.
I doubt this really matters in practice but I want to see if somebody
else has an opinion on this.</pre>
</blockquote>
<p><br>
</p>
<p>We should check riid here, but it should be already implemented
in class factory QueryInterface implementation. I'd suggest to
simply replace AddRef call with QueryInterface call.</p>
<p><br>
</p>
<p>Thanks,<br>
</p>
<p>Jacek</p>
</body>
</html>