<html><head></head><body><div class="ydpc278cad4yahoo-style-wrap" style="font-family:Helvetica Neue, Helvetica, Arial, sans-serif;font-size:16px;"><div></div>
<div dir="ltr" data-setdir="false">I noticed on Bugzilla that there was a follow up on this by Fabian Maurer. I posted my findings below his.</div><div dir="ltr" data-setdir="false"><br></div><div dir="ltr" data-setdir="false">Here is the link:</div><div dir="ltr" data-setdir="false"><br></div><div dir="ltr" data-setdir="false"><span><a href="https://bugs.winehq.org/show_bug.cgi?id=47489" rel="nofollow" target="_blank" class="">https://bugs.winehq.org/show_bug.cgi?id=47489</a></span><div><br></div><div><br></div><div dir="ltr" data-setdir="false">Here is what I wrote:</div></div><div dir="ltr" data-setdir="false"><div><pre class="ydpa33d773ebz_comment_text" id="ydpa33d773ecomment_text_3" style="font-size: 13.3333px; white-space: pre-wrap; width: 50em; color: rgb(0, 0, 0);">"I've been working on this one while learning Wine code. I wrote an app for this a while ago using some Windows API calls.
What I found was that for a Combobox the CB_SETITEMHEIGHT message was taking precedence over SetWindowPos() in Wine, whereas in Windows the last one called is what takes precedence.
I noticed that CB_SETITEMHEIGHT locks the height in in the function GB_GetTextAreaHeight() in dlls/comctl32/combo.c (and probably in the user32/combo.c as well).
I'm not familiar enough with Wine's code to make a repair right now, but, at the very least, this shows a divergence between Wine and Windows.
I'll study the code more to see if I can fix it."</pre></div><br></div><div dir="ltr" data-setdir="false">Regards,</div><div dir="ltr" data-setdir="false">...John Alway</div>
</div><div id="yahoo_quoted_3217434152" class="yahoo_quoted">
<div style="font-family:'Helvetica Neue', Helvetica, Arial, sans-serif;font-size:13px;color:#26282a;">
<div>
On Wednesday, October 30, 2019, 07:10:59 PM CDT, Thales <thaleslv@yahoo.com> wrote:
</div>
<div><br></div>
<div><br></div>
<div><div id="yiv3478150348"><div><div class="yiv3478150348ydp98b68e64yahoo-style-wrap" style="font-family:Helvetica Neue, Helvetica, Arial, sans-serif;font-size:16px;"><div></div>
<div><br clear="none"></div><div dir="ltr"><div><div dir="ltr">Hello Alistair.</div><div dir="ltr"><br clear="none"></div><div dir="ltr">I'm working on Bug #47489</div><div dir="ltr">"The appearance of configurable options in Audacity is broken"<br clear="none"></div><div dir="ltr"><br clear="none"></div><div dir="ltr"><a rel="nofollow" shape="rect" target="_blank" href="https://bugs.winehq.org/show_bug.cgi?id=47489" style="color:rgb(25, 106, 212);text-decoration-line:underline;">https://bugs.winehq.org/show_bug.cgi?id=47489</a><div><br clear="none"></div><div><br clear="none"></div><div dir="ltr">Basically the bug is that comboboxes are displayed with the wrong height.</div><div dir="ltr"><br clear="none"></div><div dir="ltr">I see that I may have written the test in the wrong way. I wrote my test in Visual Studio on Windows. It demonstrates the error by honing in on some api calls. However, I just read the article linked below under the heading "Writing Tests". Is that the way I should go about writing my test? </div><div dir="ltr"><br clear="none"></div><div dir="ltr"><a rel="nofollow" shape="rect" class="yiv3478150348" target="_blank" href="https://www.codeweavers.com/about/blogs/aeikum/2019/1/17/working-on-wine-part-5-fixing-wine" style="color:rgb(25, 106, 212);text-decoration-line:underline;">https://www.codeweavers.com/about/blogs/aeikum/2019/1/17/working-on-wine-part-5-fixing-wine</a><div><br clear="none"></div><div><br clear="none"></div></div><div><br clear="none"></div><div dir="ltr">Thanks for your feedback!</div><div dir="ltr"><br clear="none"></div><div dir="ltr">...John Alway</div><div dir="ltr"><br clear="none" style="color:rgb(0, 0, 0);font-family:Helvetica Neue, Helvetica, Arial, sans-serif;font-size:16px;"></div></div></div><br clear="none"></div>
</div><div class="yiv3478150348yqt6706265934" id="yiv3478150348yqt73765"><div class="yiv3478150348yahoo_quoted" id="yiv3478150348yahoo_quoted_2519100399">
<div style="font-family:'Helvetica Neue', Helvetica, Arial, sans-serif;font-size:13px;color:#26282a;">
<div>
On Tuesday, October 29, 2019, 11:58:58 PM CDT, Alistair Leslie-Hughes <leslie_alistair@hotmail.com> wrote:
</div>
<div><br clear="none"></div>
<div><br clear="none"></div>
<div><div id="yiv3478150348"><div>
<p>Hi John,</p>
<p>What bug are you referring to?<br clear="none">
</p>
<p>If the patch isn't too big, sent it the list without a signoff and a comment asking for a review.</p>
<p>And/Or attach it the bug report, however reviews aren't done on bugzilla patches, but the code wouldn't be lost either.</p>
<p>Regards</p>
<p>Alistair.<br clear="none">
</p>
<p><br clear="none">
</p>
<div class="yiv3478150348yqt5984671279" id="yiv3478150348yqt92213"><div class="yiv3478150348moz-cite-prefix">On 30/10/19 3:39 pm, Thales wrote:<br clear="none">
</div>
<blockquote type="cite">
<div class="yiv3478150348yahoo-style-wrap" style="font-family:Helvetica Neue, Helvetica, Arial, sans-serif;font-size:16px;">
<div dir="ltr">Hello everyone,</div>
<div dir="ltr"><br clear="none">
</div>
<div dir="ltr">I was able to figure out the source of a bug for one of the bugs listed in Bugzilla. I wrote a little demo app with Windows API functions to show it. I hesitated to fix the problem in Wine, because the code is complex and
therefore wasn't sure what the ramifications would be.</div>
<div dir="ltr"><br clear="none">
</div>
<div dir="ltr">How do I go about presenting this to those who deal with bugs? </div>
<div dir="ltr"><br clear="none">
</div>
<div dir="ltr">Many thanks for any feedback!</div>
<div dir="ltr"><br clear="none">
</div>
<div dir="ltr">Regards,</div>
<div dir="ltr">John Alway</div>
</div>
</blockquote></div>
</div></div></div>
</div>
</div></div></div></div></div>
</div>
</div></body></html>