<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=iso-8859-1">
<style type="text/css" style="display:none;"> P {margin-top:0;margin-bottom:0;} </style>
</head>
<body dir="ltr">
<div style="font-family: Calibri, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">
Hi <font style="font-size:11pt" face="Calibri, sans-serif" color="#000000">Matteo</font>,</div>
<div style="font-family: Calibri, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">
<br>
</div>
<div style="font-family: Calibri, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">
I'll fix up the patch as suggested.</div>
<div style="font-family: Calibri, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">
<br>
</div>
<div style="font-family: Calibri, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">
No the game still doesn't run with this patch, however if AddFragments return S_OK,</div>
<div style="font-family: Calibri, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">
then it does run with graphical glitches as expected.</div>
<div style="font-family: Calibri, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">
<br>
</div>
<div style="font-family: Calibri, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">
Alistair.<br>
</div>
<div>
<div id="appendonsend"></div>
<div style="font-family:Calibri,Helvetica,sans-serif; font-size:12pt; color:rgb(0,0,0)">
<br>
</div>
<hr tabindex="-1" style="display:inline-block; width:98%">
<div id="divRplyFwdMsg" dir="ltr"><font style="font-size:11pt" face="Calibri, sans-serif" color="#000000"><b>From:</b> Matteo Bruni <matteo.mystral@gmail.com><br>
<b>Sent:</b> Wednesday, 27 November 2019 9:50 PM<br>
<b>To:</b> Alistair Leslie-Hughes <leslie_alistair@hotmail.com><br>
<b>Cc:</b> wine-devel@winehq.org <wine-devel@winehq.org><br>
<b>Subject:</b> Re: [PATCH] d3dx9: Implement D3DXCreateFragmentLinker/Ex</font>
<div> </div>
</div>
<div class="BodyFragment"><font size="2"><span style="font-size:11pt">
<div class="PlainText">On Tue, Nov 26, 2019 at 4:06 AM Alistair Leslie-Hughes<br>
<leslie_alistair@hotmail.com> wrote:<br>
<br>
> @@ -6589,4 +6637,6 @@ START_TEST(shader)<br>
> test_registerset();<br>
> test_registerset_defaults();<br>
> test_shader_semantics();<br>
> + test_fragment_linker();<br>
> + test_fragment_linker();<br>
> }<br>
<br>
Why run it twice? Also you might want to check<br>
D3DXCreateFragmentLinkerEx() too and explicitly check that the<br>
returned interface is not NULL.<br>
In general, please use the current d3d style (period at the end of<br>
message strings, !count rather than count == 0, no calling the object<br>
"This", proper function TRACEs, ...). Also please use the heap<br>
allocation helpers.<br>
<br>
Does the game mentioned in the referenced bug work with this?<br>
</div>
</span></font></div>
</div>
</body>
</html>