<!DOCTYPE html PUBLIC "-//W3C//DTD HTML 4.01 Transitional//EN"><html><head><meta content="text/html;charset=UTF-8" http-equiv="Content-Type"></head><body ><div style="font-family: Verdana, Arial, Helvetica, sans-serif; font-size: 10pt;"><div>A size of zero violates the Vulkan spec so it should be a non-issue.<br></div><br>- Josh 🐸<br><div data-zbluepencil-ignore="true" style="" class="zmail_extra"><br><div id="Zm-_Id_-Sgn1">---- On Fri, 06 Mar 2020 00:10:40 +0000 <b>Liam Middlebrook <<a target="_blank" href="mailto:lmiddlebrook@nvidia.com">lmiddlebrook@nvidia.com</a>></b> wrote ----<br></div><br><blockquote style="border-left: 1px solid rgb(204, 204, 204); padding-left: 6px; margin: 0px 0px 0px 5px;"><div>I'm not sure that we can remove this if we keep both the alloca and heap_alloc <br>implementations in-place, to my understanding RtlAllocateHeap would run into issues <br>when given an input size of zero. <br> <br> <br>Thanks, <br> <br>Liam Middlebrook <br> <br>On 3/5/20 9:03 AM, Joshua Ashton wrote: <br>> The Vulkan spec states commandBufferCount must be greater than zero and pCommandBuffers must be a valid pointer. <br>> <br>> Signed-off-by: Joshua Ashton <<a target="_blank" href="mailto:joshua@froggi.es">joshua@froggi.es</a>> <br>> --- <br>> dlls/winevulkan/vulkan.c | 3 --- <br>> 1 file changed, 3 deletions(-) <br>> <br>> diff --git a/dlls/winevulkan/vulkan.c b/dlls/winevulkan/vulkan.c <br>> index 1cc1b4f61f..f767b86dc4 100644 <br>> --- a/dlls/winevulkan/vulkan.c <br>> +++ b/dlls/winevulkan/vulkan.c <br>> @@ -517,9 +517,6 @@ void WINAPI wine_vkCmdExecuteCommands(VkCommandBuffer buffer, uint32_t count, <br>> <br>> TRACE("%p %u %p\n", buffer, count, buffers); <br>> <br>> - if (!buffers || !count) <br>> - return; <br>> - <br>> tmp_buffers = WINEVULKAN_ALLOCA(count * sizeof(*tmp_buffers)); <br>> <br>> for (i = 0; i < count; i++) <br>> <br> <br>----------------------------------------------------------------------------------- <br>This email message is for the sole use of the intended recipient(s) and may contain <br>confidential information. Any unauthorized review, use, disclosure or distribution <br>is prohibited. If you are not the intended recipient, please contact the sender by <br>reply email and destroy all copies of the original message. <br>----------------------------------------------------------------------------------- <br> <br></div></blockquote></div><div><br></div></div><br></body></html>