<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=us-ascii">
<style type="text/css" style="display:none;"> P {margin-top:0;margin-bottom:0;} </style>
</head>
<body dir="ltr">
<div style="font-family: Calibri, Arial, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">
><font size="2"><span style="font-size:11pt">This shows that the strings will have to be stored in resources so that<br>
they can be translated.</span></font></div>
<div style="font-family: Calibri, Arial, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">
Yes. It seems that some languages use the US-English friendly names (US obviously but for example, arabic too). Others (like japanese and hebrew) have their own friendly names. Should Wine default to US-English in case of a missing translations then?</div>
<div style="font-family: Calibri, Arial, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">
I don't know actually know how turn this into a translation-based approach? Is there some previous work I could mimic perhaps?<br>
</div>
<div style="font-family: Calibri, Arial, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">
<br>
</div>
<div style="font-family: Calibri, Arial, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">
><font size="2"><span style="font-size:11pt">It seems to me that it's the missing name case that should be considered<br>
broken.</span></font><br>
</div>
<div style="font-family: Calibri, Arial, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">
Yes, Kosovo may not have been the best choice for the test. I think there are other universally unavailable candidates such as Europe or Africa and I shall add a test case for that.</div>
<div style="font-family: Calibri, Arial, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">
<br>
</div>
<div style="font-family: Calibri, Arial, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">
-aaro<br>
</div>
<div id="appendonsend"></div>
<hr style="display:inline-block;width:98%" tabindex="-1">
<div id="divRplyFwdMsg" dir="ltr"><font face="Calibri, sans-serif" style="font-size:11pt" color="#000000"><b>From:</b> Alexandre Julliard <julliard@winehq.org><br>
<b>Sent:</b> Monday, March 23, 2020 1:18 PM<br>
<b>To:</b> Aaro Altonen <a.altonen@hotmail.com><br>
<b>Cc:</b> wine-devel@winehq.org <wine-devel@winehq.org><br>
<b>Subject:</b> Re: [PATCH] kernelbase: Implement GEO_FRIENDLYNAME for GetGeoInfoW()</font>
<div> </div>
</div>
<div class="BodyFragment"><font size="2"><span style="font-size:11pt;">
<div class="PlainText">Aaro Altonen <a.altonen@hotmail.com> writes:<br>
<br>
> + if ((LANGIDFROMLCID(GetSystemDefaultLCID()) != MAKELANGID(LANG_ENGLISH, SUBLANG_ENGLISH_US)) ||<br>
> + (LANGIDFROMLCID(GetThreadLocale()) != MAKELANGID(LANG_ENGLISH, SUBLANG_ENGLISH_US)))<br>
> + {<br>
> + skip("Non US-English locale\n");<br>
> + }<br>
<br>
This shows that the strings will have to be stored in resources so that<br>
they can be translated.<br>
<br>
> + else<br>
> + {<br>
> + buffA[0] = 0;<br>
> + ret = pGetGeoInfoA(203, GEO_FRIENDLYNAME, buffA, 20, 0);<br>
> + ok(ret == 7, "got %d, expected 7\n", ret);<br>
> + ok(!strcmp(buffA, "Russia"), "got %s, expected Russia\n", buffA);<br>
> +<br>
> + /* Kosovo does not have a friendly name (except on win10) */<br>
> + SetLastError(0xdeadbeef);<br>
> + buffA[0] = 0;<br>
> + ret = pGetGeoInfoA(9914689, GEO_FRIENDLYNAME, buffA, 20, 0);<br>
> + ok(ret == 0 || broken(ret == 7) /* win10 */, "got %d, expected 0\n", ret);<br>
<br>
It seems to me that it's the missing name case that should be considered<br>
broken.<br>
<br>
-- <br>
Alexandre Julliard<br>
julliard@winehq.org<br>
</div>
</span></font></div>
</body>
</html>