<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=UTF-8">
</head>
<body>
<div class="moz-cite-prefix">On 01.06.2020 14:17, Gabriel Ivăncescu
wrote:<br>
</div>
<blockquote type="cite"
cite="mid:cd6984a8-ea75-b1af-dbda-9c4d028dab7e@gmail.com">On
29/05/2020 19:53, Jacek Caban wrote:
<br>
<blockquote type="cite" style="color: #000000;">On 26.05.2020
14:41, Gabriel Ivăncescu wrote:
<br>
<blockquote type="cite" style="color: #000000;">diff --git
a/dlls/msscript.ocx/msscript.c b/dlls/msscript.ocx/msscript.c
<br>
index 6d098cd..7a18a84 100644
<br>
--- a/dlls/msscript.ocx/msscript.c
<br>
+++ b/dlls/msscript.ocx/msscript.c
<br>
@@ -106,6 +106,9 @@ struct ScriptControl {
<br>
IAdviseSink *view_sink;
<br>
DWORD view_sink_flags;
<br>
+ /* modules */
<br>
+ IScriptModuleCollection IScriptModuleCollection_iface;
<br>
+
<br>
ScriptHost *host;
<br>
};
<br>
</blockquote>
<br>
<br>
It looks like it could be a separated object (which could
potentially help with your references problem).
<br>
<br>
<br>
Jacek
<br>
<br>
</blockquote>
<br>
It makes no difference if it's a separate object in this case. The
module collection is tied to the control: updating the control
(via put_Language for example) will also update an existing module
collection, not just newly obtained ones, as tests show.</blockquote>
<p><br>
</p>
<p>It may make a difference, depending on implementation details.
The potentially problematic part of your solution is that
collection shares reference counter with control instead of having
a separated ref count. It means that collection keeps the whole
control alive (which may or may not be desired, it should be
testable).</p>
<p><br>
</p>
<p>Thanks,</p>
<p>Jacek<br>
</p>
</body>
</html>