<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=UTF-8">
</head>
<body>
<div class="moz-cite-prefix">On 22.01.2021 18:44, Paul Gofman wrote:<br>
</div>
<blockquote type="cite"
cite="mid:937810cd-ca31-c2b2-4a97-7c5c44c76c43@codeweavers.com">
<blockquote type="cite" style="color: #007cff;">
<pre class="moz-quote-pre" wrap="">
xsave is part of SSE2, not AVX, and it should ignore unsupported
requested features, so the patch should be fine as is on hardware
without AVX. xsave needs, however, to be enabled by OS, so we may need
a feature check if we want to support OSes without xsave enabled.
</pre>
</blockquote>
<pre class="moz-quote-pre" wrap="">There was a real bug with that:
<a class="moz-txt-link-freetext" href="https://bugs.winehq.org/show_bug.cgi?id=50271" moz-do-not-send="true">https://bugs.winehq.org/show_bug.cgi?id=50271</a>.
</pre>
</blockquote>
<p><br>
</p>
<p>Looking at the bug report, I think it was about missing AVX
support, not missing XSAVE support, so it should be fine with my
patches.</p>
<p><br>
</p>
<p>I would need to do testing to be sure, but I noticed that our
feature detection looks suspicious. I would expect that we should
do something like the attached patch (but if it's right, it would
also need fixes in ntdll).<br>
</p>
<p><br>
</p>
<p>Jacek<br>
</p>
</body>
</html>