<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=UTF-8">
</head>
<body>
<p>after removing the false positives of GCC11 misleading
indentation warning, a couple of what looks like true positives:</p>
<p><br>
</p>
<p><b>dinput8/tests/hid.c:4122 (and same construct line 4480 also)</b></p>
<p><<< current code >>><br>
</p>
<p> if (i == 0 || i == 3) todo_wine_if( i == 0 )<br>
ok( res == WAIT_TIMEOUT, "WaitForSingleObject succeeded\n"
);<br>
else ok( res == WAIT_OBJECT_0, "WaitForSingleObject
failed\n" ); ResetEvent( event );<br>
</p>
<p>the last ResetEvent( event ) call looks badly placed. could
someone knowledgeable with the test look into it?<br>
</p>
<p><br>
<b><br>
</b><b>wininet/internet.c:2878</b><br>
if(!lpwhh) {<br>
SetLastError(ERROR_INTERNET_INCORRECT_HANDLE_TYPE);<br>
return FALSE;<br>
} else if(*(ULONG*)lpBuffer &
(~(INTERNET_ERROR_MASK_INSERT_CDROM|<br>
INTERNET_ERROR_MASK_COMBINED_SEC_CERT|<br>
INTERNET_ERROR_MASK_LOGIN_FAILURE_DISPLAY_ENTITY_BODY))) {<br>
SetLastError(ERROR_INVALID_PARAMETER);<br>
ret = FALSE;<br>
} else if(dwBufferLength != sizeof(ULONG)) {<br>
SetLastError(ERROR_INTERNET_BAD_OPTION_LENGTH);<br>
ret = FALSE;<br>
} else<br>
TRACE("INTERNET_OPTION_ERROR_MASK: %x\n",
*(ULONG*)lpBuffer);<br>
lpwhh->ErrorMask = *(ULONG*)lpBuffer;<br>
<br>
the last assignment (lpwhh->ErrorMask = *(ULONG*)lpBuffer;)<br>
is either badly indented, or misses a block<br>
could someone knowledgeable with the test look into it?</p>
<p><br>
</p>
<p>TIA<br>
</p>
<p><br>
</p>
<p><br>
</p>
</body>
</html>