<div dir="ltr"><div dir="ltr"><br></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Wed, Oct 6, 2021 at 5:12 PM Paul Gofman <<a href="mailto:pgofman@codeweavers.com">pgofman@codeweavers.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">On 10/6/21 17:01, David Kahurani wrote:<br>
> The if clause here does not make much sense and<br>
> would probably get optimized out by a smart compiler<br>
<br>
Can you please explain why it would be optimized out, exactly? if clause <br>
does make some sense, it makes fixme: displayed just once per process <br>
instead of spamming it great amount of times.<br></blockquote><div><br></div><div>Didn't take into consideration the storage specifier, sorry and thanks for pointing that out.</div><div><br></div><div>Without the storage classifier static this would have been dead code. In other words, code always gives the same result in which case a compiler would replace it with the result instead.<br></div><div> <br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
<br>
<br>
> Signed-off-by: David Kahurani <<a href="mailto:k.kahurani@gmail.com" target="_blank">k.kahurani@gmail.com</a>><br>
> ---<br>
>   dlls/ntdll/unix/system.c | 6 +-----<br>
>   1 file changed, 1 insertion(+), 5 deletions(-)<br>
><br>
> diff --git a/dlls/ntdll/unix/system.c b/dlls/ntdll/unix/system.c<br>
> index 82c9f0d..88050fb 100644<br>
> --- a/dlls/ntdll/unix/system.c<br>
> +++ b/dlls/ntdll/unix/system.c<br>
> @@ -2399,7 +2399,6 @@ NTSTATUS WINAPI NtQuerySystemInformation( SYSTEM_INFORMATION_CLASS class,<br>
>       case SystemPerformanceInformation:  /* 2 */<br>
>       {<br>
>           SYSTEM_PERFORMANCE_INFORMATION spi;<br>
> -        static BOOL fixme_written = FALSE;<br>
>   <br>
>           get_performance_info( &spi );<br>
>           len = sizeof(spi);<br>
> @@ -2409,10 +2408,7 @@ NTSTATUS WINAPI NtQuerySystemInformation( SYSTEM_INFORMATION_CLASS class,<br>
>               else memcpy( info, &spi, len);<br>
>           }<br>
>           else ret = STATUS_INFO_LENGTH_MISMATCH;<br>
> -        if(!fixme_written) {<br>
> -            FIXME("info_class SYSTEM_PERFORMANCE_INFORMATION\n");<br>
> -            fixme_written = TRUE;<br>
> -        }<br>
> +        FIXME("info_class SYSTEM_PERFORMANCE_INFORMATION\n");<br>
>           break;<br>
>       }<br>
>   <br>
<br>
<br>
</blockquote></div></div>