<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=UTF-8">
</head>
<body>
<div class="moz-cite-prefix">Le 12/10/2021 à 20:37, Alexandre
Julliard a écrit :<br>
</div>
<blockquote type="cite" cite="mid:87sfx65btk.fsf@wine">
<pre class="moz-quote-pre" wrap="">Eric Pouech <a class="moz-txt-link-rfc2396E" href="mailto:eric.pouech@orange.fr"><eric.pouech@orange.fr></a> writes:
</pre>
<blockquote type="cite">
<pre class="moz-quote-pre" wrap="">Le 12/10/2021 à 18:17, Alexandre Julliard a écrit :
</pre>
<blockquote type="cite">
<pre class="moz-quote-pre" wrap="">Eric Pouech <a class="moz-txt-link-rfc2396E" href="mailto:eric.pouech@orange.fr"><eric.pouech@orange.fr></a> writes:
</pre>
<blockquote type="cite">
<pre class="moz-quote-pre" wrap="">i'm currently fixing a couple of bugs introduced when linking winedbg with msvcrt (cough cough)
a couple of items strike me (for cross compiling only):
- why is cross compilation done with -Wno-format flag? what's the rationale behind it (it hides a couple of errors ;-)
</pre>
</blockquote>
<pre class="moz-quote-pre" wrap="">It's disabled on 64-bit because most places are still using the Unix
formats. This will have to be fixed eventually, and -Wno-format will
then be applied to non-Mingw builds instead.
</pre>
</blockquote>
<pre class="moz-quote-pre" wrap="">
you mean replacing all the the %l[udx] (lower case l) by %I[udx]
(upper case i) ?
</pre>
</blockquote>
<pre class="moz-quote-pre" wrap="">
Yes, but there are other issues, like the fact that we use long instead
of int on 32-bit. It will take some thought to find a way to do the
transition without having to fix a million warnings at once.
</pre>
</blockquote>
<p><font face="Helvetica, Arial, sans-serif">for the record, out of
the 1300 Mafile.in in the wine tree, only ~180(*) generate
warnings when removing the -Wno-format<br>
</font></p>
<p><font face="Helvetica, Arial, sans-serif"><br>
</font></p>
<p><font face="Helvetica, Arial, sans-serif">this really calls for
removing the -Wno-format and add the -Wno-format on a per
directory basis</font></p>
<p><font face="Helvetica, Arial, sans-serif">would such a thing be
acceptable?</font></p>
<p><font face="Helvetica, Arial, sans-serif"><br>
</font></p>
<p><font face="Helvetica, Arial, sans-serif">i tried currently with
hijacking EXTRAINCL (by appending the -Wno-format in
Makefile.in) and tweaking makedep to support it</font></p>
<p><font face="Helvetica, Arial, sans-serif">in the tweaking, I made
the flag inheritable across the PARENT relationship (hence the
(*) count above is an underestimation as all subdirs with PARENT
are not included in the count)</font></p>
<p><font face="Helvetica, Arial, sans-serif">but that's not 100%
satisfactory, isn't it?<br>
</font></p>
<p><font face="Helvetica, Arial, sans-serif"><br>
</font></p>
<p><font face="Helvetica, Arial, sans-serif">I was rather tempted to
add the attributes format in .h files only when
WINE_NO_ATTRIBUTE_FORMAT isn't defined, and append for subdirs
that don't support it that define to the EXTRADEF</font></p>
<p><font face="Helvetica, Arial, sans-serif"><br>
</font></p>
<p><font face="Helvetica, Arial, sans-serif">comments welcomed</font></p>
<p><font face="Helvetica, Arial, sans-serif">A+<br>
</font></p>
</body>
</html>