<div dir="ltr"><div dir="ltr">I tried that prior to adding the kernelbase stubs and unfortunately it did not work. Specifically, the function VideoCodecsXboxFeaturesEnabled is called and gets aborted if the function is unimplemented. I did not want to resort to adding these function stubs since they are essentially useless in Wine, but I don't see another way to get it to work.<div><br></div><div>One thing to note is that the function ApiSetQueryApiSetPresence is invoked: "0360:fixme:ntdll:ApiSetQueryApiSetPresence (L"ext-ms-mf-pal-l2-1-0", 000000000011E9E0) stub!"<br><br>I don't know if this is a bad idea, but would it be possible to just forward unimplemented API set function calls to a general function that returns false? This would avoid having to integrate them.</div></div></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Fri, Nov 26, 2021 at 5:45 AM Nikolay Sivov <<a href="mailto:nsivov@codeweavers.com">nsivov@codeweavers.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
<div>
<br>
<br>
<div>On 11/26/21 1:21 PM, Mohamad Al-Jaf
wrote:<br>
</div>
<blockquote type="cite">
<div dir="ltr">Hi Nikolay,
<div><br>
</div>
<div>Agreed, it does seem like it should not belong to
kernelbase but the function is there in the Windows 10
kernelbase.dll binary.</div>
<div><br>
</div>
<div>As far as I know, these dlls are part of an API set. To me,
it seems much more efficient if there was a way to integrate
them into the core dlls rather than add individual dlls. But I
don't know if this is possible at the moment. </div>
<div><br>
</div>
<div>What do you think? Which dll is more appropriate for these
functions?</div>
</div>
</blockquote>
<br>
Ideally, we wouldn't be integrating them anywhere. Does it work with
just stub entries in api set dll, without forwards?<br>
<br>
<blockquote type="cite"><br>
<div class="gmail_quote">
<div dir="ltr" class="gmail_attr">On Fri, Nov 26, 2021 at 4:45
AM Nikolay Sivov <<a href="mailto:nsivov@codeweavers.com" target="_blank">nsivov@codeweavers.com</a>> wrote:<br>
</div>
<blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">I
don't think this belongs to kernelbase, same for patch 3/4.
Whether we<br>
want internal API at all to accommodate for native dlls is
another question.<br>
<br>
</blockquote>
</div>
</blockquote>
<br>
</div>
</blockquote></div>