<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=UTF-8">
</head>
<body>
<div class="moz-cite-prefix">On 12/2/21 2:20 PM, Gabriel Ivăncescu
wrote:<br>
</div>
<blockquote type="cite"
cite="mid:50d886a7-7fe4-91a0-b8bf-83d5e79f1782@gmail.com">On
01/12/2021 21:24, Jacek Caban wrote:
<br>
<blockquote type="cite" style="color: #007cff;">Hi Gabriel,
<br>
<br>
On 12/1/21 2:41 PM, Gabriel Ivăncescu wrote:
<br>
<blockquote type="cite" style="color: #007cff;">+
if(dispex_compat_mode(This) >= COMPAT_MODE_IE8) {
<br>
+ V_VT(&var) = VT_NULL;
<br>
+ builtin_propput(This, func, &dp,
NULL);
<br>
+ }
<br>
</blockquote>
<br>
<br>
That doesn't seem universally right, see the attached test for
an example.
<br>
<br>
<br>
Thanks,
<br>
<br>
Jacek
<br>
<br>
</blockquote>
<br>
Are you sure this is related to this patch? I did some digging but
it seems to be a completely different issue to me. This patch is
about removeAttribute returning false and setting to NULL, which
happens with event handlers.
</blockquote>
<p><br>
</p>
<p>Yes, the existing code is already wrong, we probably shouldn't
blindly try to set value to VT_EMPTY in the first place. Trying to
set the property to another value (of type that doesn't make sense
unless you assume that those are event handlers) based on a
previous error that we know nothing about (it could be OOM?) is
making it even worse. Is there another reason for this patch than
a todo_wine in tests?</p>
<p><br>
</p>
<p>Thanks,</p>
<p>Jacek<br>
</p>
</body>
</html>