<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=UTF-8">
</head>
<body>
<div class="moz-cite-prefix">Le 03/03/2022 à 11:33, Huw Davies a
écrit :<br>
</div>
<blockquote type="cite" cite="mid:20220303103302.GC2872900@pinot">
<pre class="moz-quote-pre" wrap="">On Thu, Mar 03, 2022 at 11:25:02AM +0100, Eric Pouech wrote:
</pre>
<blockquote type="cite">
<pre class="moz-quote-pre" wrap="">Le 03/03/2022 à 10:58, Huw Davies a écrit :
On Wed, Mar 02, 2022 at 09:03:33AM +0100, Eric Pouech wrote:
Signed-off-by: Eric Pouech <a class="moz-txt-link-rfc2396E" href="mailto:eric.pouech@gmail.com"><eric.pouech@gmail.com></a>
---
dlls/nsi/tests/Makefile.in | 1
dlls/nsi/tests/nsi.c | 202 ++++++++++++++++++++++--
--------------------
2 files changed, 101 insertions(+), 102 deletions(-)
Let's hold off on this one until we[1] decide what to do
about nsiproxy and potentially include/wine/nsi.h
Huw.
[1] The ball's in my court on this.
Hi Huw
yes makes sense
[1] and on Alexandre's too... it's not decided yet which strategy to adopt on
unixlib part
</pre>
</blockquote>
<pre class="moz-quote-pre" wrap="">
Right, but in this case, since we can change the header file,
one solution is to change the DWORDs to unsigned int / UINT32
and then the problem goes away and doesn't require Alexandre
to think about it ;-)
Huw.
</pre>
</blockquote>
<p><font face="Helvetica, Arial, sans-serif">yes but <br>
</font></p>
<p><font face="Helvetica, Arial, sans-serif">1) we're looking for a
solution that could be applied to all unixlib:s<br>
</font></p>
<p><font face="Helvetica, Arial, sans-serif">2) in nsiproxy case, it
boils down to changing all DWORD -> UINT into, yes,
include/wine/nsi.h, but also in most of unixlib code, and also
the protocol between the two<br>
</font></p>
<p><font face="Helvetica, Arial, sans-serif"><br>
</font></p>
<p><font face="Helvetica, Arial, sans-serif">just for fun (picking
up randomly <g>):</font></p>
<p><font face="Helvetica, Arial, sans-serif">(from
dlls/winealsa.drv/unixlib.h)<br>
</font></p>
<p><font face="Helvetica, Arial, sans-serif">struct
is_format_supported_params<br>
{<br>
const char *alsa_name;<br>
EDataFlow flow;<br>
AUDCLNT_SHAREMODE share;<br>
const WAVEFORMATEX *fmt_in;<br>
WAVEFORMATEXTENSIBLE *fmt_out;<br>
HRESULT result;<br>
};<br>
most of those internal structures shoulb be converted</font></p>
<p><font face="Helvetica, Arial, sans-serif">doable, but requires
lots of changes</font></p>
<p><font face="Helvetica, Arial, sans-serif">A+<br>
</font></p>
</body>
</html>