<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=UTF-8">
</head>
<body>
<div class="moz-cite-prefix">On 4/11/22 12:42, Eric Pouech wrote:<br>
</div>
<blockquote type="cite"
cite="mid:b653bbcd-6fed-c32f-a3b9-052e66e06f37@orange.fr">
<blockquote type="cite" style="color: #007cff;">BTW, I'd also
consider WARN() instead of once+FIXME() for console_ioctl().
<br>
</blockquote>
<br>
the rationale behind this one was to be able to track when some
program ends up using Console* interface while being attached to
the shell_no_screen console type
<br>
<br>
this could be complicated to track or understand
<br>
<br>
(actually an ERR would be perhaps more suited than a FIXME)
</blockquote>
<p><br>
</p>
<p>ERR() is usually for cases that should not happen. Those ioctl()s
may legitimately happen and in some cases they may even be desired
bevavior, so I'm not sure that any debug channel that is turned on
by default is appropriate. I'd hope that retval=0 from a console
function call in relay logs will not be too hard to spot (and then
+console could clarify that with a WARN()).</p>
<p><br>
</p>
<p>Thanks,</p>
<p>Jacek<br>
</p>
</body>
</html>