<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=UTF-8">
</head>
<body>
<div class="moz-cite-prefix">On 6/1/22 15:48, Gabriel Ivăncescu
wrote:<br>
</div>
<blockquote type="cite"
cite="mid:943bf7f0-306a-e169-4831-f223683259f8@gmail.com">On
01/06/2022 03:07, Jacek Caban wrote:
<br>
<blockquote type="cite" style="color: #007cff;">On 5/31/22 16:56,
Gabriel Ivăncescu wrote:
<br>
<blockquote type="cite" style="color: #007cff;">Instead of only
interpreted functions. Property retrievals or setters are
<br>
allowed though, as long as they are not accessors.
<br>
<br>
Signed-off-by: Gabriel Ivăncescu<a
class="moz-txt-link-rfc2396E"
href="mailto:gabrielopcode@gmail.com" moz-do-not-send="true"><gabrielopcode@gmail.com></a>
<br>
---
<br>
<br>
Note that native GetDispID seem to fail when retrieving
builtin/prototype
<br>
functions (?) if script is uninitialized, but retrieving the
DISPID before and
<br>
using it after it's uninitialized still works, though (that's
what the tests
<br>
do). I don't think it's worth replicating this GetDispID quirk
for the moment.
<br>
</blockquote>
<br>
<br>
I'm not really concerned about GetDispID quirks, but implication
of your choice for the next patch. I think that releasing
objects sooner is better, so it would be good to have a better
argument for moving that. Your reasoning there is based on
details of how you decided to not follow native here.
<br>
<br>
<br>
More generally, creating function objects in response for
property get is an implementation detail that supposed to be
transparent. If it's causing problems elsewhere, I'd first look
at making it more transparent. In this case, maybe we should
create function objects sooner, in response to GetDispID. This
would both match all tests and allow us to release function
constructor sooner.
<br>
<br>
<br>
Jacek
<br>
<br>
</blockquote>
<br>
Right, but how is releasing such objects not an implementation
detail as well?</blockquote>
<p><br>
</p>
<p>It's an exposed behaviour, see the attached test. BTW, having
tests like that may be nice to catch leaks and test GC in the
future.<br>
</p>
<p><br>
</p>
<p>Jacek<br>
</p>
</body>
</html>