Really do not roll up if selection is being tracked by arrowkeys in the dropdown listbox

Dmitry Timoshkov dmitry at sloboda.ru
Fri Apr 6 10:08:26 CDT 2001


Hello.

Win2000 never rolls up listbox (in combobox) even if CBS_SIMPLE bit is set.

Changelog:
    Dmitry Timoshkov <dmitry at codeweavers.com>
    Really do not roll up if selection is being tracked by arrowkeys
    in the dropdown listbox.

diff -u cvs/hq/wine/controls/combo.c wine/controls/combo.c
--- cvs/hq/wine/controls/combo.c	Tue Mar 20 23:10:06 2001
+++ wine/controls/combo.c	Fri Apr  6 21:54:11 2001
@@ -1422,9 +1422,7 @@
 
 		/* do not roll up if selection is being tracked 
 		 * by arrowkeys in the dropdown listbox */
-
-                if( (lphc->dwStyle & CBS_SIMPLE) ||
-                    ((lphc->wState & CBF_DROPPED) && !(lphc->wState & CBF_NOROLLUP)) )
+                if( ((lphc->wState & CBF_DROPPED) && !(lphc->wState & CBF_NOROLLUP)) )
                 {
                    CBRollUp( lphc, (HIWORD(wParam) == LBN_SELCHANGE), TRUE );
                 }
diff -u cvs/hq/wine/controls/listbox.c wine/controls/listbox.c
--- cvs/hq/wine/controls/listbox.c	Tue Feb 27 06:31:55 2001
+++ wine/controls/listbox.c	Fri Apr  6 21:54:11 2001
@@ -2307,7 +2307,7 @@
         LISTBOX_SetSelection( wnd, descr, caret, TRUE, FALSE);
         if (descr->style & LBS_NOTIFY)
         {
-	    if( descr->lphc && CB_GETTYPE(descr->lphc) != CBS_SIMPLE )
+	    if( descr->lphc )
             {
 		/* make sure that combo parent doesn't hide us */
 		descr->lphc->wState |= CBF_NOROLLUP;






More information about the wine-patches mailing list