Remove redundant sending of WM_DRAWITEM message to ownerdrawn combobox

Dmitry Timoshkov dmitry at sloboda.ru
Sat Apr 14 12:52:49 CDT 2001


Hello.

Currently if ownerdrawn combobox is dropped down and you will try
to navigate using DOWN/UP keys, combobox gets corrupted.

Changelog:
    Dmitry Timoshkov <dmitry at codeweavers.com>
    Remove redundant sending of WM_DRAWITEM message to ownerdrawn combobox.

--- cvs/hq/wine/controls/combo.c	Tue Apr 10 08:46:46 2001
+++ wine/controls/combo.c	Sat Apr 14 19:38:58 2001
@@ -748,6 +748,8 @@
 
    if( lphc->wState & CBF_NOREDRAW ) return;
 
+   TRACE("\n");
+
    /* follow Windows combobox that sends a bunch of text 
     * inquiries to its listbox while processing WM_PAINT. */
 
@@ -981,6 +983,7 @@
   hDC = (hParamDC) ? hParamDC
 		   : BeginPaint( lphc->self->hwndSelf, &ps);
 
+  TRACE("hdc=%04x\n", hDC);
 
   if( hDC && !(lphc->wState & CBF_NOREDRAW) )
   {
@@ -1429,17 +1432,6 @@
 		else lphc->wState &= ~CBF_NOROLLUP;
 
 		CB_NOTIFY( lphc, CBN_SELCHANGE );
-
-		/* added due to traces from native */
-		if( CB_OWNERDRAWN(lphc) ) 
-		{
-		    HDC hDC;
-
-		    hDC = GetDC( hWnd );
-		    CBPaintText( lphc, hDC, lphc->textRect);
-		    ReleaseDC( hWnd, hDC );
-		}
-		/* end of added due to traces from native */
 
 		/* fall through */
 






More information about the wine-patches mailing list