[PATCH] Fix incorrect return from MIX_SetControlDetails()

James Hatheway james at macadamian.com
Fri Apr 20 09:25:31 CDT 2001


Hi guys,

Inside of the function MIX_SetControlDetails, at the top
it creates a variable called ret (initially assigned MMSYSERR_NOTSUPPORTED).
In my case, execution drops through the switch statements to the
MIXER_GETCONTROLDETAILSF_VALUE -> MIXERCONTROL_CONTROLTYPE_MUTE cases.  The value
MMSYSERR_NOERROR is then assigned to ret.  Unfortunately, at the bottom, ret is not
returned, instead MMSYSERR_NOTSUPPORTED is (hardcoded)! So, let's make sure that
we use the return variable.


-James

Changelog:
  James Hatheway - james at macadamian.com
  Make sure to return our variable with the correct return value.

Modified:
  dlls/winmm/wineoss/mixer.c



--
James Hatheway
Software Designer - Macadamian Technologies, Inc.
james at macadamian.com ~ http://www.macadamian.com

  "Man könnte froh sein, wenn die Luft so rein wäre wie das Bier"
  "One could be happy if the air were as pure as the beer"
-------------- next part --------------
A non-text attachment was scrubbed...
Name: mix_SetControlDetails_fix.diff
Type: application/octet-stream
Size: 590 bytes
Desc: not available
Url : http://www.winehq.org/pipermail/wine-patches/attachments/20010420/5c326675/mix_SetControlDetails_fix.obj


More information about the wine-patches mailing list