GetControlBrush16 patch
Marco Bizzarri
m.bizzarri at icube.it
Wed Aug 1 11:24:02 CDT 2001
Hi all.
This is my first patch so please be patient.
The problem I've found is in the GetControlBrush16. While looking at a
way to remove a goto, I've seen that a wndPtr could be released twice...
I'm not sure this is a bug, however I've removed it, and I'm including
the patch.
Let me know
Bye
Marco
--
Marco Bizzarri - Responsabile Tecnico - Icube S.r.l.
Sede: Via Ridolfi 15 - 56124 Pisa (PI), Italia
E-mail: m.bizzarri at icube.it WWW: www.icube.it
Tel: (+39) 050 97 02 07 Fax: (+39) 050 31 36 588
-------------- next part --------------
--- windows/painting.c Wed Aug 1 18:05:05 2001
+++ windows/painting.c.orig Wed Aug 1 18:04:13 2001
@@ -490,12 +490,12 @@
if( !parent ) parent = wndPtr;
retvalue = (HBRUSH16)PAINT_GetControlBrush( parent->hwndSelf, hwnd, hdc, ctlType );
WIN_ReleaseWndPtr(parent);
- if ( parent != wndPtr )
- WIN_ReleaseWndPtr( wndPtr );
- return retvalue;
+ goto END;
}
+ retvalue = (HBRUSH16)0;
+END:
WIN_ReleaseWndPtr(wndPtr);
- return (HBRUSH16)0;
+ return retvalue;
}
More information about the wine-patches
mailing list