Misc / Unicode

Francois Gouget fgouget at free.fr
Tue Feb 6 07:32:27 CST 2001


On Tue, 6 Feb 2001, Huw D M Davies wrote:
[...]
> > +static const WCHAR RICHEDIT_CLASS20W[] = { 'R','i','c','h','E','d','i','t','2','0','W' };
> 
> Doesn't this want a trailing 0 ?

   Oops, it does indeed. Here's the updated patch, please ignore the
previous one.

<rant>
I checked the other cases and I have this question. Why does everyone
use 0 instead of '\0', 0 instead of FALSE, and '\0' instead of NULL? MS
even does the reverse and uses NULL in places where '\0' or 0 would have
been more appropriate. Man, if you know what you're doing prove it and
use the appropriate form: either 0, '\0' or NULL.
I know this comes from from someone who just forgot to put a trailing
'\0'. But still.
</rant>


--
Francois Gouget         fgouget at free.fr        http://fgouget.free.fr/
              Linux: Because rebooting is for adding new hardware
-------------- next part --------------
Index: include/richedit.h
===================================================================
RCS file: /home/cvs/wine/wine/include/richedit.h,v
retrieving revision 1.4
diff -u -r1.4 richedit.h
--- include/richedit.h	2001/01/22 19:25:27	1.4
+++ include/richedit.h	2001/01/29 11:01:27
@@ -15,7 +15,7 @@
 #define cchTextLimitDefault 0x7fff
 
 #define RICHEDIT_CLASS20A	"RichEdit20A"
-#define RICHEDIT_CLASS20W	L"RichEdit20W"
+static const WCHAR RICHEDIT_CLASS20W[] = { 'R','i','c','h','E','d','i','t','2','0','W', '\0' };
 #define RICHEDIT_CLASS10A	"RICHEDIT"
 
 #if (_RICHEDIT_VER >= 0x0200 )
Index: dlls/shell32/shlview.c
===================================================================
RCS file: /home/cvs/wine/wine/dlls/shell32/shlview.c,v
retrieving revision 1.56
diff -u -r1.56 shlview.c
--- dlls/shell32/shlview.c	2000/11/28 22:40:58	1.56
+++ dlls/shell32/shlview.c	2001/01/29 11:01:14
@@ -105,13 +105,11 @@
 
 #define SHV_CHANGE_NOTIFY WM_USER + 0x1111
 
-#define TOOLBAR_ID   (L"SHELLDLL_DefView")
 /*windowsx.h */
 #define GET_WM_COMMAND_ID(wp, lp)               LOWORD(wp)
 #define GET_WM_COMMAND_HWND(wp, lp)             (HWND)(lp)
 #define GET_WM_COMMAND_CMD(wp, lp)              HIWORD(wp)
-/* winuser.h */
-#define WM_SETTINGCHANGE                WM_WININICHANGE
+
 extern void WINAPI _InsertMenuItem (HMENU hmenu, UINT indexMenu, BOOL fByPosition, 
 			UINT wID, UINT fType, LPSTR dwTypeData, UINT fState);
 


More information about the wine-patches mailing list