-DSTRICT warning fixes

Patrik Stridvall ps at leissner.se
Fri Jul 27 16:08:32 CDT 2001


Concerning some parts of my warnings patch that was 
partly rejected I disagree with the rejection.
The patch in question is in warnings_rejected.diff.
Note the field "u" is a union. But perhaps you know
and rejected it for other reasons?

In other news:
Quite suprisingly I managed get Wine to
compile with -DSTRICT without any STRICT related
warnings. I have test it even without -DSTRICT
and it doesn't introduce any new warnings either.

If you accept all the strict_*.diff patches, perhaps we
should consider adding -DSTRICT as a permanent flag?
It removes the HOOKPROC/TIMERPROC warnings that is not
possible to fix otherwise.

If we do that can just do
s/DECLARE_OLD_HANDLE/DECLARE_HANDLE/
on the handle types on by one and fix the warnings.

I have provided no patch to do that, but if you agree
you can quite easily do it yourself.

---8<---

*** strict_bugs

* dlls/shell32/shellord.c,
  include/wine/undocshell.h:
Compiled with -DSTRICT and fixed some bugs.

*** strict_warnings

* dlls/rasapi32/rasapi.c,
  dlls/shell32/shellole.c,
  dlls/user/dde/client.c,
  dlls/user/dde/ddeml16.c,
  dlls/user/dde/misc.c,
  dlls/user/dde/server.c,
  include/ddeml.h,
  include/shellapi.h,
  include/vfw.h,
  include/windef.h,
  windows/user.c:
Compiled with -DSTRICT and fixed some warnings.

*** strict_errors

* windows/property.c:
Compiled with -DSTRICT and fixed some errors.

*** warnings_rejected

* dlls/ole32/clipboard.c,
  dlls/ole32/ole2.c:
Fixed some warnings.

-------------- next part --------------
A non-text attachment was scrubbed...
Name: strict_bugs.diff
Type: application/octet-stream
Size: 2098 bytes
Desc: not available
Url : http://www.winehq.org/pipermail/wine-patches/attachments/20010727/8b7eb1ec/strict_bugs.obj
-------------- next part --------------
A non-text attachment was scrubbed...
Name: strict_errors.diff
Type: application/octet-stream
Size: 1068 bytes
Desc: not available
Url : http://www.winehq.org/pipermail/wine-patches/attachments/20010727/8b7eb1ec/strict_errors.obj
-------------- next part --------------
A non-text attachment was scrubbed...
Name: strict_warnings.diff
Type: application/octet-stream
Size: 10070 bytes
Desc: not available
Url : http://www.winehq.org/pipermail/wine-patches/attachments/20010727/8b7eb1ec/strict_warnings.obj
-------------- next part --------------
A non-text attachment was scrubbed...
Name: warnings_rejected.diff
Type: application/octet-stream
Size: 1595 bytes
Desc: not available
Url : http://www.winehq.org/pipermail/wine-patches/attachments/20010727/8b7eb1ec/warnings_rejected.obj


More information about the wine-patches mailing list