Changes to Toolbar.C, support for TBSTYLE_DROPDOWN

Guy L. Albertelli galberte at neo.lrun.com
Tue Jul 31 21:20:44 CDT 2001


IE4 now is able to display the "Favorites" dropdown list (not the frame).
The proper icons are also displayed. Selection of an item should work. The
"menu" and "Links" list now matches the native control in width of the
buttons and text (not the height).

Known problems:
- Height of TBSTYLE_LIST toolbars not correct (native 20 pixels, builtin
22).
  May also be due to either Rebar or Pager.
- No arrow is drawn in the "Favorites" dropdown. In native, this is not an
  arrow but some other character, so I expect that it is a "special"
character
  and not a drawn arrow.
- Native issues many NM_CUSTOMDRAWs and the dropdown box is
TBSTYLE_CUSTOMERASE.
- Native highlights "Favorites" dropdown item with a blue background, the
  builtin makes it "raised".
- Native automatically selects "Favorites" dropdown item that is a folder
and
  displays that dropdown. The builtin requires a left click on the item to
  display the sub-dropdown.
- TBSTYLE_FLAT should be transparent but is not.
- Selection of second folder in "Favorites" results in invalid list items
  from previous folder.


Tested with IE4 against v4.71 of comctl32.
Visually checked against Toolbar.exe, Rebar.exe, WinRAR, Wordpad, Win95 file
dialog box, Winzip 8.0

Changelog
 Guy Albertelli  <<galberte at neo.lrun.com>>

  dlls/comctl32/toolbar.c
    - Add debugging dumps of bar and buttons, and trace entry for each
message.
    - Organize WM_NOTIFY processing in preparation for Unicode
    - Implement TBN_GETDISPINFO and I_IMAGECALLBACK for bitmaps.
    - Implement drawing of separator for TBSTYLE_DROPDOWN similar to native.
    - Change drawing of buttons to support TBSTYLE_LIST and make match
      native pixel layout (with and without bitmaps).
    - Change TOOLBAR_MeasureString to measure with DrawText like native.
      This eliminates extra space due to prefix char ("&").
    - Speed up TOOLBAR_CalcStrings by doing the HDC and FONT selection once.
    - Change calc of buttons to match drawing for TBSTYLE_LIST and
separators.

-------------- next part --------------
A non-text attachment was scrubbed...
Name: toolbar4.diff
Type: application/octet-stream
Size: 34338 bytes
Desc: not available
Url : http://www.winehq.org/pipermail/wine-patches/attachments/20010731/e9cff8e9/toolbar4.obj


More information about the wine-patches mailing list