docu update

Andreas Mohr a.mohr at mailto.de
Mon Jun 4 13:05:14 CDT 2001


Hi all,

- update BUGS status
- remove WINAPI
- add offsets to PE struct
- improve debug output
- improve rgapi description output

Andreas Mohr
-------------- next part --------------
Determining best CVS host...
Using CVSROOT :pserver:cvs at rhlx01.fht-esslingen.de:/home/wine
Index: BUGS
===================================================================
RCS file: /home/wine/wine/BUGS,v
retrieving revision 1.5
diff -u -r1.5 BUGS
--- BUGS	2000/01/29 21:12:58	1.5
+++ BUGS	2001/06/04 16:02:48
@@ -1,3 +1,5 @@
+***** this file is horribly outdated - please update ! *****
+
 For information on how to post a useful bug report, please
 read documentation/bugreports.
 
@@ -20,14 +22,14 @@
 
  * Very alpha printing code using win16 drivers.
 
- * Very alpha internal PostScript driver. [h.davies1 at physics.ox.ac.uk]
+ * internal PostScript driver not finished. [h.davies1 at physics.ox.ac.uk]
 
  * Extremely alpha Win95 interface code (some apps, like Opera, choke on it).
 
  * No OLE2 and OLE32 support (including OLE2 interfaces etc.).
 	 (started work on pidl-handling, IShellFolders IEnumIdLists 
 	 and SH* functions juergen.schmied at metronet.de)	
-	(Corel is working on it)
+	(Corel has been working on it)
 
  * No MS Video support. [just started, marcus at jet.franken.de]
 
Index: dlls/version/info.c
===================================================================
RCS file: /home/wine/wine/dlls/version/info.c,v
retrieving revision 1.30
diff -u -r1.30 info.c
--- dlls/version/info.c	2001/03/23 19:07:35	1.30
+++ dlls/version/info.c	2001/06/04 16:02:48
@@ -267,7 +267,7 @@
  *    in the case if file exists, but VERSION_INFO not found.
  *    FIXME: handle is not used.
  */
-static DWORD WINAPI VERSION_GetFileVersionInfo_PE( LPCSTR filename, LPDWORD handle,
+static DWORD VERSION_GetFileVersionInfo_PE( LPCSTR filename, LPDWORD handle,
                                     DWORD datasize, LPVOID data )
 {
     VS_FIXEDFILEINFO *vffi;
@@ -346,7 +346,7 @@
  *    in the case if file exists, but VERSION_INFO not found.
  *    FIXME: handle is not used.
  */
-static DWORD WINAPI VERSION_GetFileVersionInfo_16( LPCSTR filename, LPDWORD handle,
+static DWORD VERSION_GetFileVersionInfo_16( LPCSTR filename, LPDWORD handle,
                                     DWORD datasize, LPVOID data )
 {
     VS_FIXEDFILEINFO *vffi;
Index: include/winnt.h
===================================================================
RCS file: /home/wine/wine/include/winnt.h,v
retrieving revision 1.89
diff -u -r1.89 winnt.h
--- include/winnt.h	2001/05/18 20:58:43	1.89
+++ include/winnt.h	2001/06/04 16:02:50
@@ -2032,44 +2032,44 @@
 
   /* Standard fields */
 
-  WORD  Magic;
+  WORD  Magic; /* 0x10b or 0x107 */	/* 0x00 */
   BYTE  MajorLinkerVersion;
   BYTE  MinorLinkerVersion;
   DWORD SizeOfCode;
   DWORD SizeOfInitializedData;
   DWORD SizeOfUninitializedData;
-  DWORD AddressOfEntryPoint;
+  DWORD AddressOfEntryPoint;		/* 0x10 */
   DWORD BaseOfCode;
   DWORD BaseOfData;
 
   /* NT additional fields */
 
   DWORD ImageBase;
-  DWORD SectionAlignment;
+  DWORD SectionAlignment;		/* 0x20 */
   DWORD FileAlignment;
   WORD  MajorOperatingSystemVersion;
   WORD  MinorOperatingSystemVersion;
   WORD  MajorImageVersion;
   WORD  MinorImageVersion;
-  WORD  MajorSubsystemVersion;
+  WORD  MajorSubsystemVersion;		/* 0x30 */
   WORD  MinorSubsystemVersion;
   DWORD Win32VersionValue;
   DWORD SizeOfImage;
   DWORD SizeOfHeaders;
-  DWORD CheckSum;
+  DWORD CheckSum;			/* 0x40 */
   WORD  Subsystem;
   WORD  DllCharacteristics;
   DWORD SizeOfStackReserve;
   DWORD SizeOfStackCommit;
-  DWORD SizeOfHeapReserve;
+  DWORD SizeOfHeapReserve;		/* 0x50 */
   DWORD SizeOfHeapCommit;
   DWORD LoaderFlags;
   DWORD NumberOfRvaAndSizes;
-  IMAGE_DATA_DIRECTORY DataDirectory[IMAGE_NUMBEROF_DIRECTORY_ENTRIES];
+  IMAGE_DATA_DIRECTORY DataDirectory[IMAGE_NUMBEROF_DIRECTORY_ENTRIES]; /* 0x60 */
 } IMAGE_OPTIONAL_HEADER, *PIMAGE_OPTIONAL_HEADER;
 
 typedef struct _IMAGE_NT_HEADERS {
-  DWORD Signature;
+  DWORD Signature; /* "PE"\0\0 */
   IMAGE_FILE_HEADER FileHeader;
   IMAGE_OPTIONAL_HEADER OptionalHeader;
 } IMAGE_NT_HEADERS, *PIMAGE_NT_HEADERS;
Index: objects/region.c
===================================================================
RCS file: /home/wine/wine/objects/region.c,v
retrieving revision 1.37
diff -u -r1.37 region.c
--- objects/region.c	2001/04/23 18:11:41	1.37
+++ objects/region.c	2001/06/04 16:02:52
@@ -1237,7 +1237,7 @@
 
 	if (src1Obj)
 	{
-	    TRACE("dump:\n");
+	    TRACE("dump src1Obj:\n");
 	    if(TRACE_ON(region)) 
 	      REGION_DumpRegion(src1Obj->rgn);
 	    if (mode == RGN_COPY)
@@ -1251,7 +1251,7 @@
 
 		if (src2Obj)
 		{
-		    TRACE("dump:\n");
+		    TRACE("dump src2Obj:\n");
 		    if(TRACE_ON(region)) 
 		        REGION_DumpRegion(src2Obj->rgn);
 		    switch (mode)
@@ -1275,7 +1275,7 @@
 	    }
 	    GDI_ReleaseObj( hSrc1 );
 	}
-	TRACE("dump:\n");
+	TRACE("dump destObj:\n");
 	if(TRACE_ON(region)) 
 	  REGION_DumpRegion(destObj->rgn);
 
Index: programs/regapi/regapi.c
===================================================================
RCS file: /home/wine/wine/programs/regapi/regapi.c,v
retrieving revision 1.13
diff -u -r1.13 regapi.c
--- programs/regapi/regapi.c	2001/02/14 21:43:06	1.13
+++ programs/regapi/regapi.c	2001/06/04 16:02:52
@@ -169,15 +169,16 @@
  */
 static char helpText[] =
 "NAME\n"
-"          regapi - provide a command line interface to the wine registry.\n"
+"          regapi - perform certain actions on the wine registry.\n"
 "\n"
 "SYNOPSIS\n"
 "          regapi commandName [-force] < file\n"
 "\n"
 "DESCRIPTION\n"
-"          regapi allows editing the wine registry.  It processes the given\n"
-"          commandName for every line in the stdin data stream.  Input data\n"
-"          format may vary depending on the commandName see INPUT FILE FORMAT.\n"
+"          regapi modifies settings in the wine registry.  It processes\n"
+"          the given commandName for every line in the stdin data stream.\n"
+"          Input data format may vary depending on the commandName\n"
+"          (see INPUT FILE FORMAT).\n"
 "\n"
 "OPTIONS\n"
 "          commandName\n"
@@ -997,8 +998,8 @@
 }
 
 /******************************************************************************
- * MAIN - The main simply validate the first parameter (command to perform)
- *        It then read the STDIN lines by lines forwarding their processing
+ * MAIN - WinMain simply validates the first parameter (command to perform)
+ *        It then reads the STDIN lines by lines forwarding their processing
  *        to the appropriate method.
  */
 int PASCAL WinMain (HINSTANCE inst, HINSTANCE prev, LPSTR cmdline, int show)
Index: win32/file.c
===================================================================
RCS file: /home/wine/wine/win32/file.c,v
retrieving revision 1.28
diff -u -r1.28 file.c
--- win32/file.c	2001/05/29 20:55:22	1.28
+++ win32/file.c	2001/06/04 16:02:52
@@ -103,7 +103,7 @@
     if (-1==chmod(full_name.long_name,buf.st_mode))
     {
         FILE_SetDosError();
-        MESSAGE("Wine ERROR: Couldn't set file attributes for existing file \"%s\". Check permissions or set VFAT \"quiet\" flag !\n", full_name.long_name);
+        MESSAGE("Wine ERROR: Couldn't set file attributes for existing file \"%s\". Check permissions or set VFAT \"quiet\" mount flag !\n", full_name.long_name);
         return TRUE;
     }
     return TRUE;


More information about the wine-patches mailing list