winemaker

[Francois Gouget]

On Fri, 12 Oct 2001 lawson_whitney at juno.com wrote:
[...]
> Well, would it be appropriate for winemaker to generate a rudimentary
> script?  Or would you rather leave that to the individual Winelib
> developer?

   I don't know. I did not look into it so I don't know if winemaker can
generate a meaningful and useful script. If the script does no more than
the symlink then it's not really worth it. But a more complex script
would most likely require customization. I want to keep this simple...
   Also I am not sure how to integrate such a script: it is the Makefile
which will be generating the script. So we do we store the template? In
an extra file?
   I think that for now it's best to leave it as is.


[...]
> _list=""; for i in $_list); do (cd $i; make install) || exit 1; done
> /bin/sh: -c: line 1: syntax error near unexpected token `;'
> /bin/sh: -c: line 1: `_list=""; for i in $_list); do (cd $i; make install) || exit 1; done'
> make: *** [install] Error 2
> 
> I guess that must be an old autoconf.  Everything else I think should be
> pretty well up to date.

   No, it's a stray parenthesis in winemaker :-(
Here is a fixed patch. This one should work.


--
Francois Gouget         fgouget at free.fr        http://fgouget.free.fr/
The nice thing about meditation is that it makes doing nothing quite respectable
                                  -- Paul Dean

-------------- next part --------------
Index: tools/winemaker
===================================================================
RCS file: /home/wine/wine/tools/winemaker,v
retrieving revision 1.35
diff -u -r1.35 winemaker
--- tools/winemaker	2001/10/12 18:41:26	1.35
+++ tools/winemaker	2001/10/13 01:22:58
@@ -1908,22 +1908,22 @@
   if (@$project[$P_PATH] eq "") {
     # This is the main project. It is also responsible for recursively 
     # calling the other projects
-    print FILEO "\tfor i in \$(SUBDIRS); do (cd \$\$i; \$(MAKE) install) || exit 1; done\n";
+    print FILEO "\t_list=\"\$(SUBDIRS)\"; for i in \$\$_list; do (cd \$\$i; \$(MAKE) install) || exit 1; done\n";
   }
   if (@{@$project[$P_TARGETS]} > 0) {
-    print FILEO "\tfor i in \$(EXES); do \$(INSTALL_PROGRAM) \$\$i \$(bindir); done\n";
-    print FILEO "\tfor i in \$(EXES:%=%.so) \$(DLLS); do \$(INSTALL_PROGRAM) \$\$i \$(libdir); done\n";
+    print FILEO "\t_list=\"\$(EXES) \$(EXES:%=%.so)\"; for i in \$\$_list; do \$(INSTALL_PROGRAM) \$\$i \$(bindir); done\n";
+    print FILEO "\t_list=\"\$(DLLS)\"; for i in \$\$_list; do \$(INSTALL_PROGRAM) \$\$i \$(libdir); done\n";
   }
   print FILEO "\n";
   print FILEO "uninstall::\n";
   if (@$project[$P_PATH] eq "") {
     # This is the main project. It is also responsible for recursively 
     # calling the other projects
-    print FILEO "\tfor i in \$(SUBDIRS); do (cd \$\$i; \$(MAKE) uninstall) || exit 1; done\n";
+    print FILEO "\t_list=\"\$(SUBDIRS)\"; for i in \$\$_list; do (cd \$\$i; \$(MAKE) uninstall) || exit 1; done\n";
   }
   if (@{@$project[$P_TARGETS]} > 0) {
-    print FILEO "\tfor i in \$(EXES); do \$(RM) \$(bindir)/\$\$i;done\n";
-    print FILEO "\tfor i in \$(EXES:%=%.so) \$(DLLS); do \$(RM) \$(libdir)/\$\$i;done\n";
+    print FILEO "\t_list=\"\$(EXES) \$(EXES:%=%.so)\"; for i in \$\$_list; do \$(RM) \$(bindir)/\$\$i;done\n";
+    print FILEO "\t_list=\"\$(DLLS)\"; for i in \$\$_list; do \$(RM) \$(libdir)/\$\$i;done\n";
   }
   print FILEO "\n\n\n";