Fix the kernel/path tests

Francois Gouget fgouget at free.fr
Tue Dec 17 21:15:46 CST 2002


All filenames containing a ":" are invalid on Win9x and 2000 but are
valid on NT4.

    file:000.ext
    file000.e:t
    :file000.ext
    file000:.ext
    Long : File
    : Long File
    Long File :

The reason we did not detect that problem is that the test files did
not exist and the error code on Win9x just happened to match. However
Windows 2000 refused such filenames and returned ERROR_INVALID_NAME.

So there is not really much we can test and I just removed these tests.
(using CreateFile would have been a better approach to determine whether
these are valid filenames or not anyway)


Changelog:

 * dlls/kernel/tests/path.c

   All filenames containing a ":" are invalid on Win9x and 2000 but are
valid on NT4 -> remove these tests


Index: dlls/kernel/tests/path.c
===================================================================
RCS file: /home/wine/wine/dlls/kernel/tests/path.c,v
retrieving revision 1.12
diff -u -r1.12 path.c
--- dlls/kernel/tests/path.c	18 Dec 2002 02:22:51 -0000	1.12
+++ dlls/kernel/tests/path.c	18 Dec 2002 02:45:08 -0000
@@ -792,14 +792,6 @@
     sprintf(tmpstr,"Long File %c",funny_chars[i]);
     test_FunnyChars(curdir,tmpstr,valid,0,tmpstr1);
   }
-/* ':' is a special case and is allowed only in certain cases */
-    test_FunnyChars(curdir,"file:000.ext",1,0,"check-1");
-    test_FunnyChars(curdir,"file000.e:t" ,1,0,"check-2");
-    test_FunnyChars(curdir,":file000.ext",0,1,"check-3");
-    test_FunnyChars(curdir,"file000:.ext",1,0,"check-4");
-    test_FunnyChars(curdir,"Long : File" ,1,0,"check-5");
-    test_FunnyChars(curdir,": Long File" ,0,0,"check-6");
-    test_FunnyChars(curdir,"Long File :" ,0,0,"check-7");
 }

 static void test_GetTempPathA(char* tmp_dir)



-- 
Francois Gouget         fgouget at free.fr        http://fgouget.free.fr/
 Advice is what we ask for when we already know the answer but wish we didn't
                                 -- Eric Jong




More information about the wine-patches mailing list