flaky regression(?) - patch.py?id=1012510895681951425038278 - fixed.

lawson_whitney at juno.com lawson_whitney at juno.com
Tue Feb 5 23:24:26 CST 2002


Good day!

This is up for discussion on wine-devel, but if nobody has a better way
to suggest, it is better than what was there.  I attached one in case
the inlined one folds.  Is that reasonable?  Or would you rather I
didn't?

Lawson

ChangeLog:
	* dlls/ole32/storage32.c:
	Lawson Whitney <lawson_whitney at juno.com>
	Fix off-by-one error in placing trailing \0.
	
diff -ur was/dlls/ole32/storage32.c is/dlls/ole32/storage32.c
--- was/dlls/ole32/storage32.c	Mon Feb  4 17:31:22 2002
+++ is/dlls/ole32/storage32.c	Tue Feb  5 22:11:20 2002
@@ -5615,7 +5615,7 @@
   /* prepare the file name string given in lieu of the root property name */
   GetFullPathNameW(pwcsName, MAX_PATH, fullname, NULL);
   memcpy(newStorage->filename, fullname, PROPERTY_NAME_BUFFER_LEN);
-  newStorage->filename[PROPERTY_NAME_BUFFER_LEN] = '\0';
+  newStorage->filename[PROPERTY_NAME_BUFFER_LEN-1] = '\0';

   /*
    * Get an "out" pointer for the caller.
-------------- next part --------------
diff -ur was/dlls/ole32/storage32.c is/dlls/ole32/storage32.c
--- was/dlls/ole32/storage32.c	Mon Feb  4 17:31:22 2002
+++ is/dlls/ole32/storage32.c	Tue Feb  5 22:11:20 2002
@@ -5615,7 +5615,7 @@
   /* prepare the file name string given in lieu of the root property name */
   GetFullPathNameW(pwcsName, MAX_PATH, fullname, NULL);
   memcpy(newStorage->filename, fullname, PROPERTY_NAME_BUFFER_LEN);
-  newStorage->filename[PROPERTY_NAME_BUFFER_LEN] = '\0';
+  newStorage->filename[PROPERTY_NAME_BUFFER_LEN-1] = '\0';
 
   /*
    * Get an "out" pointer for the caller.


More information about the wine-patches mailing list