Listview label edit bug fix

Duane Clark dclark at akamail.com
Wed Feb 27 22:13:55 CST 2002


This is a particularly insidious bug. If a label is put into edit mode, 
when the focus was killed, it deleted the last letter of the label. And 
when this is a file, it actually renames the file!

Log message:
	Ask for correct number of chars in EditLblWndProcT.

-------------- next part --------------
Index: dlls/comctl32/listview.c
===================================================================
RCS file: /home/wine/wine/dlls/comctl32/listview.c,v
retrieving revision 1.120
diff -u -r1.120 listview.c
--- dlls/comctl32/listview.c	2002/02/27 01:24:39	1.120
+++ dlls/comctl32/listview.c	2002/02/28 02:09:05
@@ -9747,14 +9748,14 @@
         
 	if (!cancel)
 	{
-	    DWORD len = 1 + isW ? GetWindowTextLengthW(hwnd) : GetWindowTextLengthA(hwnd);
+	    DWORD len = isW ? GetWindowTextLengthW(hwnd) : GetWindowTextLengthA(hwnd);
 
 	    if (len)
 	    {
 		if ( (buffer = COMCTL32_Alloc((len+1) * (isW ? sizeof(WCHAR) : sizeof(CHAR)))) )
 		{
-		    if (isW) GetWindowTextW(hwnd, buffer, len);
-		    else GetWindowTextA(hwnd, (CHAR*)buffer, len);
+		    if (isW) GetWindowTextW(hwnd, buffer, len+1);
+		    else GetWindowTextA(hwnd, (CHAR*)buffer, len+1);
 		}
 	    }
 	}


More information about the wine-patches mailing list